fix(db): align API-key oracle grants in schema dump#2167
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes anonymous/public access to two API key-related database functions by revoking ChangesAPI Key Function Access Control
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
|



Summary
anongrants for API-key oracle RPCs fromsupabase/schemas/prod.sql20260427105909_fix_apikey_helper_rpc_public_execute.sqland the existing pgTAP expectationsauthenticatedandservice_roleexecute grants unchanged/claim #1667
Test plan
git diff --checkanongrants forget_user_id(text),get_user_id(text,text), orget_org_perm_for_apikey(text,text)insupabase/schemas/prod.sqlnpx --yes bun@latest run lint:sql -- supabase/schemas/prod.sqlcould not run locally becausesqlfluffis not installed in this environmentNotes
No new migration is needed here: the migration chain already revokes these grants. This patch fixes the schema dump so fresh schema-based resets do not reintroduce the anonymous RPC surface.
Summary by CodeRabbit