Skip to content

[codex] remove channel preview eye button#2276

Merged
riderx merged 1 commit into
mainfrom
codex/remove-channel-preview-eye
May 17, 2026
Merged

[codex] remove channel preview eye button#2276
riderx merged 1 commit into
mainfrom
codex/remove-channel-preview-eye

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 17, 2026

Summary (AI generated)

  • Removed the preview eye button shown next to the channel bundle number.
  • Removed the now-unused preview handler and icon import from the channel detail page.

Motivation (AI generated)

The channel detail page should not expose a preview eye action beside the bundle/build number.

Business Impact (AI generated)

This keeps the console UI aligned with the expected channel management workflow and removes a confusing control from a high-traffic app settings page.

Test Plan (AI generated)

  • Ran bun lint.
  • Commit hook ran bun run cli:build and vue-tsc --noEmit.

Screenshots (AI generated)

Not included. This is a small removal of one icon button from the channel detail row.

Checklist (AI generated)

  • My code follows the code style of this project and passes the relevant frontend lint check.
  • My change does not require a change to the documentation.
  • My change has adequate E2E test coverage.
  • I have tested my code manually, and I have provided steps how to reproduce my tests.

Generated with AI

Summary by CodeRabbit

  • New Features

    • Added settings button to select and manage bundle versions, with access controlled by user permissions.
  • Changes

    • Removed preview navigation action from bundle number display.

Review Change Stack

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f615d8ed-c90e-4b28-b703-639b36afdeb4

📥 Commits

Reviewing files that changed from the base of the PR and between 34f239c and 2d5a588.

📒 Files selected for processing (1)
  • src/pages/app/[app].channel.[channel].vue
💤 Files with no reviewable changes (1)
  • src/pages/app/[app].channel.[channel].vue

📝 Walkthrough

Walkthrough

The channel page's bundle number row replaces a preview navigation action with a settings action for bundle version selection. The IconEye import and openPreview() routing function are removed. The bundle number action button now calls openSelectVersion() and is disabled when the user lacks channel.promote_bundle permission.

Changes

Bundle version selection action replacement

Layer / File(s) Summary
Replace preview action with bundle version selection
src/pages/app/[app].channel.[channel].vue
Remove IconEye import and openPreview() function; update the bundle number InfoRow to display a settings action button that triggers openSelectVersion() and is disabled when the user lacks channel.promote_bundle permission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Cap-go/capgo#1978: Introduced the openPreview()/IconEye navigation that this PR removes, replacing it with bundle version selection at the same UI entry point.
  • Cap-go/capgo#2032: Adds a /preview tab using IconEye, while this PR removes the preview action from the bundle number row.

Poem

🐰 A preview fades, a settings light gleams,
Bundle versions flow through permission-gated dreams,
Eye icon gone, but the UI still shines,
Version selection now draws the lines!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the preview eye button from the channel interface.
Description check ✅ Passed The description includes a summary and covers testing and checklist items, though it lacks the formal template structure and manual test reproduction steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-channel-preview-eye

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 17, 2026

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing codex/remove-channel-preview-eye (2d5a588) with main (92d0d5a)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (34f239c) during the generation of this report, so 92d0d5a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sonarqubecloud
Copy link
Copy Markdown

@riderx riderx merged commit d51499a into main May 17, 2026
52 of 53 checks passed
@riderx riderx deleted the codex/remove-channel-preview-eye branch May 17, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant