feat(cli): offer Capgo Builder on incompatible upload#2368
Merged
Conversation
verifyCompatibility now reports incompatibility; uploadBundleInternal runs the Builder CTA and, on accept, skips the OTA upload and returns the chosen action. The Ink-based launch (build onboarding / build request) happens in the CLI entry point so upload.ts (and the programmatic SDK bundle) stays free of ink.
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a Builder CTA surfaced during incompatible ChangesBuilder CTA Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a2e35f53c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bundle upload's --path is the web asset dir; build request treats path as the Capacitor project root. Omitting it defaults to cwd() (the project root).
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/src/bundle/builder-cta.ts`:
- Around line 68-127: maybePromptBuilderCta can throw because several awaited
calls (loadSavedCredentials, isBuilderPromptSnoozed, confirm/pConfirm,
snoozeBuilderPrompt) are unprotected; wrap the function body or the specific
await sequences in a try/catch and on any caught error log it and return
'continue' (i.e., degrade silently rather than rethrowing). Ensure you catch
failures from loadSavedCredentials, isBuilderPromptSnoozed, the confirm/pConfirm
calls and snoozeBuilderPrompt, keep trackEvent calls as appropriate, and use
pIsCancel logic as before; the goal is to guarantee maybePromptBuilderCta always
resolves to a BuilderCtaAction instead of throwing.
In `@cli/src/index.ts`:
- Around line 175-186: Extract the inline .action body around uploadBundle into
a new exported handler function (e.g., handleUploadBundleCommand) in a dedicated
module; move the await uploadBundle(...args) call and the subsequent branching
that checks result?.builderAction and calls onboardingBuilderCommand or
requestBuildCommand into that handler, preserving the same parameter shape
(appId, options) and behavior, export it, then replace the inline async action
in cli/src/index.ts with a simple call to the imported handleUploadBundleCommand
so index.ts only wires the command and options while the implementation lives in
the new handler module.
In `@docs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.md`:
- Around line 446-481: The plan incorrectly inlines Ink-based builder commands
into uploadBundleInternal; instead change the implementation to return early
with builderAction so the CLI entry point launches Ink. Update the call to
verifyCompatibility to destructure { nativePackages, minUpdateVersion,
incompatible, incompatibleCount }, then if incompatible and not silent call
maybePromptBuilderCta (passing interactive, appId: appid, orgId, apikey,
incompatibleCount); if builderAction !== 'continue' return the skipped result
object including builderAction, reason: 'NATIVE_BUILD', bundle, checksum: null,
encryptionMethod, and storageProvider: defaultStorageProvider (do not call
onboardingBuilderCommand or requestBuildCommand here). Also remove import of
onboardingBuilderCommand and requestBuildCommand and keep only
maybePromptBuilderCta.
- Around line 505-509: Add a blank line immediately before the opening fenced
code block marker (```bash) and a blank line immediately after the closing
fenced code block marker (```) so the three lines of commands ("bunx vitest
...", "bun run --cwd cli typecheck", "bun run --cwd cli build") are separated
from surrounding text; update the fenced block delimeters (```bash and ```)
accordingly to follow Markdown best practices.
- Around line 322-356: The params interface MaybePromptBuilderCtaParams and
function maybePromptBuilderCta are missing two injected inputs: add interactive:
boolean to MaybePromptBuilderCtaParams and add confirm?: BuilderConfirm (or
similar injectable) to the maybePromptBuilderCta params; remove the internal
canPromptInteractively() call and use the passed interactive value, and replace
direct pConfirm(...) calls with the injected confirm (falling back to pConfirm
if confirm is undefined) so tests can inject a fake confirm and callers (e.g.,
upload flow) can pass interactive.
In
`@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md`:
- Line 152: The spec's BuilderCtaAction currently defines objects with a kind
field but the codebase uses a string-literal union; update the spec to match the
implementation by changing BuilderCtaAction to a string union 'continue' |
'launch-onboarding' | 'launch-build' so it aligns with the types used in
cli/src/bundle/builder-cta.ts (export type BuilderCtaAction) and the schema's
builderAction (z.enum in cli/src/schemas/bundle.ts).
- Around line 54-91: Several fenced code blocks in the doc (the top warning
block starting with "⚠️ This update changes native code...", the "No credentials
→ onboarding CTA" prompt block beginning "This update includes native
changes...", the nested confirmation block starting "Heads up: this update
includes native changes...", and the "Has credentials → build CTA" block "This
update needs a native build...") are missing language specifiers; update each
triple-backtick fence to include a language (e.g., ```text or ```shell) and add
a blank line before and after the nested confirmation fenced block to satisfy
markdownlint around that inner block.
- Around line 156-160: Update the spec to match the implemented helpers: remove
the bogus hasLocalCredentials reference and instead document using
loadSavedCredentials (which returns credentials|null) for credential detection
(see usage in builder-cta), and correct the snooze module location to the actual
builder-snooze implementation and its exported helpers isSnoozed and snooze
(i.e., reference the implemented builder-snooze module rather than a
non-existent utils/builder-snooze).
In `@tests/builder-cta.unit.test.ts`:
- Around line 51-90: Convert the tests inside the
describe('maybePromptBuilderCta') block (from the current it(...) cases starting
at the first it) to use it.concurrent(...) so they run in parallel, and
relocate/mock setup from the shared beforeEach into each test to keep them
deterministic: for each test set mockSnoozed.mockResolvedValue(false) and
mockLoadCreds.mockResolvedValue(null) (or the test-specific variant) and set
mockConfirm/mockSnooze as needed before calling maybePromptBuilderCta(params);
also call vi.resetAllMocks() or vi.clearAllMocks() at the start of each
concurrent test to isolate mocks. Reference symbols: maybePromptBuilderCta,
mockConfirm, mockSnooze, mockSnoozed, mockLoadCreds, params.
In `@tests/builder-snooze.unit.test.ts`:
- Around line 7-40: Tests share mutable globals dir and statePath and use
sequential it(...) causing races when parallelized; change each test to use
it.concurrent(...) and remove the top-level dir/statePath by creating per-test
temp dirs/statePath inside each test (or use a beforeEach that assigns local
variables scoped to the test) so calls to snoozeBuilderPrompt and
isBuilderPromptSnoozed operate on isolated files; ensure the cleanup (rmSync)
runs per-test or use tmpdir-specific removal in each test to avoid cross-test
interference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ced9a212-954f-4bc4-a0bf-c187c06567ee
📒 Files selected for processing (9)
cli/src/bundle/builder-cta.tscli/src/bundle/builder-snooze.tscli/src/bundle/upload.tscli/src/index.tscli/src/schemas/bundle.tsdocs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.mddocs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.mdtests/builder-cta.unit.test.tstests/builder-snooze.unit.test.ts
- maybePromptBuilderCta wrapped so it never throws (degrades to continue) - extract bundle upload action into cli/src/bundle/upload-command.ts (keeps index.ts to wiring; keeps ink out of the SDK bundle) - builder-snooze tests run concurrently with per-test temp dirs - spec doc: correct BuilderCtaAction (string union), credential detection (loadSavedCredentials), snooze module path, and deferred-launch architecture
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md (1)
110-111:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix snooze file path typo in spec. The spec lists
~/.capgo/builder-prompt.json(line 110), but the implementation uses~/.capgo-builder-prompt.jsonviabuilderPromptStatePath(matches line 161). Update line 110 to~/.capgo-builder-prompt.json.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md` around lines 110 - 111, Update the spec to match the implementation: change the snooze file path string on the listed line from "~/.capgo/builder-prompt.json" to "~/.capgo-builder-prompt.json" so it matches the implementation constant/variable builderPromptStatePath referenced elsewhere; ensure the Shape description remains the same and only the file path string is corrected.
♻️ Duplicate comments (1)
docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md (1)
54-91:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winLanguage specifiers still missing from fenced code blocks.
The fenced code blocks showing prompt examples and messages still lack language identifiers (
textorshell), and the nested confirmation block (lines 77-80) still needs blank lines before and after it.📝 Proposed fix
### Non-interactive / CI Print a single warning + ad block, **no prompt**, then continue the upload unchanged: -``` +```text ⚠️ This update changes native code, so it needs a native build to reach users on current app-store binaries.Apply similar fixes to the other code blocks at lines 70, 77, and 86, and add blank lines around the nested block at 77-80 as shown in the previous review.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md` around lines 54 - 91, Add missing fenced-code language specifiers and blank lines: for the block starting with "⚠️ This update changes native code, so it needs a native build to reach users" and the other example blocks containing "This update includes native changes, which ship via an app-store build rather than OTA." and "This update needs a native build. Run one now with Capgo Builder? (Y/n)" add appropriate language tags (e.g., ```text or ```shell) to each fenced code block; also add a blank line before and after the nested confirmation block that begins "Heads up: this update includes native changes, which ship via an app-store build rather than OTA." so it is separated from surrounding fenced blocks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md`:
- Around line 110-111: Update the spec to match the implementation: change the
snooze file path string on the listed line from "~/.capgo/builder-prompt.json"
to "~/.capgo-builder-prompt.json" so it matches the implementation
constant/variable builderPromptStatePath referenced elsewhere; ensure the Shape
description remains the same and only the file path string is corrected.
---
Duplicate comments:
In
`@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md`:
- Around line 54-91: Add missing fenced-code language specifiers and blank
lines: for the block starting with "⚠️ This update changes native code, so it
needs a native build to reach users" and the other example blocks containing
"This update includes native changes, which ship via an app-store build rather
than OTA." and "This update needs a native build. Run one now with Capgo
Builder? (Y/n)" add appropriate language tags (e.g., ```text or ```shell) to
each fenced code block; also add a blank line before and after the nested
confirmation block that begins "Heads up: this update includes native changes,
which ship via an app-store build rather than OTA." so it is separated from
surrounding fenced blocks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8e76a8db-0f0f-431e-9dc3-5c80291041e9
📒 Files selected for processing (5)
cli/src/bundle/builder-cta.tscli/src/bundle/upload-command.tscli/src/index.tsdocs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.mdtests/builder-snooze.unit.test.ts
- fold the reason (native changes ship via an app-store build, not OTA) into the one prompt - drop the second 'are you sure?' confirmation — declining just continues - remove the 3-day snooze entirely (delete builder-snooze module + tests) - CAPGO_NO_BUILDER_PROMPT still opts out; spec/plan updated
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.md (1)
448-487:⚠️ Potential issue | 🟠 Major | ⚡ Quick winTask 5 still prescribes launching build commands inside
upload.ts, which conflicts with shipped architecture.This step still inlines
onboardingBuilderCommand/requestBuildCommandinuploadBundleInternal, instead of returningbuilderActionand letting the CLI entry point launch Ink flows. That reintroduces the SDK/Ink coupling the feature explicitly avoids.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.md` around lines 448 - 487, The PR inlines Ink/CLI build commands into uploadBundleInternal by calling onboardingBuilderCommand and requestBuildCommand after maybePromptBuilderCta; instead, modify uploadBundleInternal (where verifyCompatibility and maybePromptBuilderCta are used) to stop launching onboardingBuilderCommand/requestBuildCommand and instead return a result that includes the builderAction (or an explicit skipped reason) when incompatible is true so the CLI entrypoint can read that builderAction and invoke onboardingBuilderCommand/requestBuildCommand; update the returned object shape to include builderAction/incompatibleCount/skipped metadata and ensure maybePromptBuilderCta is still called here but only to produce the action, not execute it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.md`:
- Around line 13-16: The plan text still instructs implementing a removed
snooze/second-confirm flow; update the document so the actionable tasks match
the shipped single-prompt/no-snooze UX: remove or clearly mark Tasks 1/3/6 (and
any references to builder-snooze.ts, snooze tests, decline-confirmation flow,
snooze tracking) as historical/non-executable, and replace them with concise
instructions to implement and test the current flow (a single yes/no prompt with
the reason folded into the question and no snooze), including references to the
new handler/component names used in the codebase and the specific tests to
add/update for the single-prompt behavior.
---
Duplicate comments:
In `@docs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.md`:
- Around line 448-487: The PR inlines Ink/CLI build commands into
uploadBundleInternal by calling onboardingBuilderCommand and requestBuildCommand
after maybePromptBuilderCta; instead, modify uploadBundleInternal (where
verifyCompatibility and maybePromptBuilderCta are used) to stop launching
onboardingBuilderCommand/requestBuildCommand and instead return a result that
includes the builderAction (or an explicit skipped reason) when incompatible is
true so the CLI entrypoint can read that builderAction and invoke
onboardingBuilderCommand/requestBuildCommand; update the returned object shape
to include builderAction/incompatibleCount/skipped metadata and ensure
maybePromptBuilderCta is still called here but only to produce the action, not
execute it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e1e43be1-4047-4a4e-afae-bfa6b60feaa3
📒 Files selected for processing (4)
cli/src/bundle/builder-cta.tsdocs/superpowers/plans/2026-05-30-builder-cta-on-incompatible-upload.mddocs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.mdtests/builder-cta.unit.test.ts
The plan was a point-in-time execution guide; the feature shipped and the flow evolved (single prompt, no snooze, deferred Ink launch), leaving the plan's tasks inconsistent with the code. The spec remains as the design record.
- exact prompt copy: '… An app store update may be required … Capgo Builder can help you build and publish the required native update. Would you like to configure / Start a native build with Capgo Builder now?' - add an OSC 8 'Learn what Capgo Builder is' hyperlink (opens https://capgo.app/native-build/ without dismissing the prompt) - CI ad + spec updated to match
Print the explanation (and keep it out of the prompt) via log.info, then ask a short yes/no question. The clickable 'Learn what Capgo Builder is' hyperlink rides on the prompt line.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
tests/builder-cta.unit.test.ts (1)
49-79: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winConvert the
maybePromptBuilderCtacases toit.concurrent(...)and isolate their mock setup.This block still uses plain
it(...), and the sharedbeforeEach/top-level mocks will race once you switch it to concurrent execution. Move the reset/setup into each test as part of the conversion so the file actually satisfies the repo’s parallel-test requirement. As per coding guidelines,tests/**/*.test.ts: “Design all tests for parallel execution across files; use it.concurrent() instead of it() to run tests in parallel within the same file for faster CI/CD”.#!/bin/bash sed -n '43,80p' tests/builder-cta.unit.test.ts printf '\n--- non-concurrent tests in this file ---\n' rg -nP '^\s*it\s*\(' tests/builder-cta.unit.test.ts🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/builder-cta.unit.test.ts` around lines 49 - 79, Tests using maybePromptBuilderCta are not safe for parallel runs; convert each it(...) to it.concurrent(...) and move all mock setup/reset into the individual tests so they don't rely on shared beforeEach state. For each test, call mockConfirm.mockReset()/mockClear() and mockLoadCreds.mockReset()/mockClear(), then set per-test behaviors (e.g., mockConfirm.mockResolvedValueOnce(true/false), mockLoadCreds.mockResolvedValue(...) as needed) and use a fresh params object via {...params} to avoid shared mutations; keep assertions the same but ensure no top-level or shared beforeEach mocks remain that could race when using it.concurrent. Ensure references: maybePromptBuilderCta, mockConfirm, mockLoadCreds are initialized in each test body.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/src/bundle/builder-cta.ts`:
- Around line 49-55: printBuilderCiAd currently emits four separate logs; keep
the REASON warning but replace the three subsequent log.info calls with one
consolidated info line. In printBuilderCiAd(hasCredentials) build a single
message string that picks the one-line CTA based on hasCredentials (use the
existing ternary content for the command) and append the learn/docs links inline
(e.g. "→ ... Learn: ${LEARN_URL} · Docs: ${DOCS_URL}"), then call log.info
once; reference printBuilderCiAd, REASON, LEARN_URL and DOCS_URL when locating
the change.
---
Duplicate comments:
In `@tests/builder-cta.unit.test.ts`:
- Around line 49-79: Tests using maybePromptBuilderCta are not safe for parallel
runs; convert each it(...) to it.concurrent(...) and move all mock setup/reset
into the individual tests so they don't rely on shared beforeEach state. For
each test, call mockConfirm.mockReset()/mockClear() and
mockLoadCreds.mockReset()/mockClear(), then set per-test behaviors (e.g.,
mockConfirm.mockResolvedValueOnce(true/false),
mockLoadCreds.mockResolvedValue(...) as needed) and use a fresh params object
via {...params} to avoid shared mutations; keep assertions the same but ensure
no top-level or shared beforeEach mocks remain that could race when using
it.concurrent. Ensure references: maybePromptBuilderCta, mockConfirm,
mockLoadCreds are initialized in each test body.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8e08ac68-bb8c-423b-a921-0b221d92737c
📒 Files selected for processing (3)
cli/src/bundle/builder-cta.tsdocs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.mdtests/builder-cta.unit.test.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md`:
- Around line 71-73: Update the "Decisions" section language that currently
states the reason is folded into a single yes/no prompt so it matches the new
two-message prompt flow: change the note that references a single combined
prompt to explicitly describe the two-step interaction (first a context line,
then a short yes/no prompt containing the clickable "Learn what Capgo Builder
is" link (OSC 8) that opens https://capgo.app/native-build/ without dismissing
the prompt), ensuring the decision text aligns with the two-message behavior and
removes the contradictory guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: cc6faf00-21f3-4eee-ae0e-b4f5dcc371d4
📒 Files selected for processing (2)
cli/src/bundle/builder-cta.tsdocs/superpowers/specs/2026-05-30-builder-cta-on-incompatible-upload-design.md
- printBuilderCiAd now emits a single log.warn line (was 4 log calls) per CodeRabbit feedback on the CI ad block. - maybePromptBuilderCta takes hasCredentials as a param resolved by the caller (upload.ts) instead of calling loadSavedCredentials internally, so the unit tests run fully it.concurrent with no shared mock state. - Update the design spec CI-ad section to the consolidated single line.
The interactive prompt is already TTY-gated and only fires on incompatible uploads (dismissed with one keystroke); the CI path is a single log line. An env opt-out added surface area for no real use case, so remove it: - builder-cta.ts: drop envDisabled from BuilderCtaContext + the env check; decideBuilderCtaSurface now skips only on compatible bundles. - tests: remove the env-disable case (9 tests, all concurrent). - spec: drop the trigger condition, Opt-out env bullet, and Decisions note.
Resolve conflict in cli/src/bundle/upload.ts: main restructured
verifyCompatibility to return a compatibility:{result,versionOldId,
versionOldName} object (feeding the new 'Bundle Incompatible' Bento signal),
while this branch added incompatible/incompatibleCount for the Builder CTA.
Kept main's richer compatibility object plus incompatibleCount, and derive
incompatible locally from compatibility.result === 'incompatible' (no
redundant field). Both the Bento signal and the Builder CTA are preserved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
capgo bundle uploaddetects an incompatible bundle (native deps changed → a native build is required to reach users), there's nothing guiding the user toward the fix. This nudges them to Capgo Builder at exactly that moment. Builds on theBundle Upload Compatibility Checkedsignal added in #2364.Behavior
Triggered only when the bundle is incompatible (and not
--ignore-metadata-check):build onboarding.build request.CAPGO_NO_BUILDER_PROMPT=1suppresses everything.Tracking (PostHog, via existing
trackEvent)Builder CTA Shown/Accepted/Declined/Snoozed— carryappId+orgId(org-grouped) and join the existing Capgo Builder funnel.Design notes
upload.ts(and the programmatic SDK bundle) stays free ofink. The CTA decision (maybePromptBuilderCta) lives incli/src/bundle/builder-cta.ts(uses@clack/prompts, injectable for tests); the Ink-based launch runs in the CLI entry point (index.ts, which already imports those commands).uploadBundleInternaljust returns abuilderActionin its skip result.~/.capgo-builder-prompt.json(same pattern aspromptPreferences), per-app, time-injectable.loadSavedCredentials(appId).Files
cli/src/bundle/builder-snooze.ts(new) +cli/src/bundle/builder-cta.ts(new)cli/src/bundle/upload.ts,cli/src/index.ts,cli/src/schemas/bundle.tstests/builder-snooze.unit.test.ts,tests/builder-cta.unit.test.tsdocs/superpowers/specs|plans/2026-05-30-builder-cta-on-incompatible-upload*Test plan
tests/builder-snooze.unit.test.ts+tests/builder-cta.unit.test.ts— 16 passing (decision matrix, orchestrator branches, snooze set/honor/expire/per-app)bun run --cwd cli typecheck(tsgo) cleanbun run --cwd cli build— CLI + SDK build green (SDK bundle has noink)CAPGO_NO_BUILDER_PROMPT=1→ silent; piped/non-TTY → ad only, upload proceedsSummary by CodeRabbit
New Features
Documentation
Tests