Skip to content

fix: use released updater preview loader#2409

Merged
riderx merged 1 commit into
mainfrom
codex/preview-native-loader
Jun 4, 2026
Merged

fix: use released updater preview loader#2409
riderx merged 1 commit into
mainfrom
codex/preview-native-loader

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Jun 3, 2026

What

  • Bump @capgo/capacitor-updater to 8.47.7.
  • Refresh iOS SPM and Android Gradle plugin paths to the released updater package.
  • Remove the temporary Capgo-side SplashScreen preview loader workaround from the PR diff.

Why

  • The updater plugin now owns the native preview transition loader, so Capgo should use the released plugin instead of keeping app-side loader glue.

How

  • Rebased the PR onto current main.
  • Installed @capgo/capacitor-updater@^8.47.7 with Bun.
  • Ran Capacitor sync for iOS and Android.

Testing

  • bun run build
  • bun typecheck
  • bun lint
  • Commit hook typecheck

Not Tested

  • Manual native camera/deeplink preview flow on a device in this turn.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@riderx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf32b9ff-23cb-42bc-a3a9-540df6651ffb

📥 Commits

Reviewing files that changed from the base of the PR and between 33ba6c8 and c5c28d2.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • android/capacitor.settings.gradle
  • ios/App/CapApp-SPM/Package.swift
  • package.json

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Jun 3, 2026

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing codex/preview-native-loader (c5c28d2) with main (33ba6c8)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@riderx
Copy link
Copy Markdown
Member Author

riderx commented Jun 3, 2026

CI note: both Run tests jobs fail during bun typecheck before frontend typecheck runs, on unrelated backend organization onboarding type errors in supabase/functions/_backend/public/organization/post.ts and tests/organization-put-stripe-sync.unit.test.ts.

This PR only changes src/pages/scan.vue and src/services/loader.ts. Local scoped checks passed: bun run lint, bun run typecheck:frontend, and bun run build. CI Playwright, CodeQL, DeepSec, dead-code, benchmarks, and security checks passed. Keeping this draft until the backend typecheck blocker is cleared.

@riderx riderx force-pushed the codex/preview-native-loader branch from eb53a2f to c5c28d2 Compare June 4, 2026 16:15
@riderx riderx changed the title fix: show native loader during preview apply fix: use released updater preview loader Jun 4, 2026
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednode-forge@​1.4.01001001008570
Updated@​capgo/​capacitor-updater@​8.47.6 ⏵ 8.47.7100 +110010096 +170
Added@​types/​tmp@​0.2.61001007280100
Added@​types/​jsonwebtoken@​9.0.101001007381100
Addedadm-zip@​0.5.171001009781100
Addedopen@​11.0.010010010081100
Added@​standard-schema/​spec@​1.1.010010010082100
Addedci-info@​4.4.010010010084100

View full report

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

@riderx riderx marked this pull request as ready for review June 4, 2026 16:25
@riderx riderx merged commit 5217280 into main Jun 4, 2026
44 checks passed
@riderx riderx deleted the codex/preview-native-loader branch June 4, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant