Skip to content

fix(ios): remove invalid underscore URL scheme for App Store upload#2431

Merged
WcaleNieWolny merged 1 commit into
mainfrom
wolny/ios-fix-url-scheme
Jun 4, 2026
Merged

fix(ios): remove invalid underscore URL scheme for App Store upload#2431
WcaleNieWolny merged 1 commit into
mainfrom
wolny/ios-fix-url-scheme

Conversation

@WcaleNieWolny
Copy link
Copy Markdown
Contributor

@WcaleNieWolny WcaleNieWolny commented Jun 4, 2026

What

Remove the ee.forgr.capacitor_go entry from CFBundleURLSchemes in ios/App/App/Info.plist. Keep capgo.

Why

The iOS build compiles, archives, and reaches App Store Connect upload, where altool rejects it (run https://github.com/Cap-go/capgo/actions/runs/26937037211):

The following URL schemes found in your app are not in the correct format: [ee.forgr.capacitor_go].
URL schemes need to begin with an alphabetic character, and be comprised of alphanumeric
characters, the period, the hyphen or the plus sign only. (90158)

ee.forgr.capacitor_go contains an underscore, which RFC1738 / Apple disallow in URL schemes.

It's safe to remove:

  • Unreferenced — no usages in src/, capacitor.config.ts, or iOS deep-link handling.
  • No Android counterpart — Android uses https (universal links) + capgo; no reverse-DNS scheme.
  • Never functioned — underscores are invalid, so nothing could have used it as a scheme.
  • CFBundleURLName is already ee.forgr.capacitorgo (no underscore); only the scheme string had it.

The real custom scheme capgo is preserved.

If a reverse-DNS scheme is wanted for the future, the valid form is ee.forgr.capacitorgo — but since it's unused, removal is the minimal fix.

Verification

  • plutil -lint passes.
  • New tag from main + Build mobile ios: confirm App Store Connect upload is accepted (no 90158 URL-scheme rejection).

Summary by CodeRabbit

  • Chores
    • Updated iOS app URL scheme identifier configuration.

App Store Connect rejects the iOS upload:

  The following URL schemes found in your app are not in the correct format:
  [ee.forgr.capacitor_go]. URL schemes need to begin with an alphabetic
  character, and be comprised of alphanumeric characters, the period, the
  hyphen or the plus sign only. (90158)

CFBundleURLSchemes listed ee.forgr.capacitor_go (underscore), which RFC1738
disallows. It's unused: nothing in src/, capacitor.config.ts, or iOS deep-link
handling references it, there's no Android counterpart, and underscores can
never have functioned as a scheme. The real custom scheme is 'capgo' (kept).
Remove the invalid entry so the upload is accepted.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ee51bd3b-d2d9-487e-8380-a5b0616e2011

📥 Commits

Reviewing files that changed from the base of the PR and between 7031192 and bad16ca.

📒 Files selected for processing (1)
  • ios/App/App/Info.plist

📝 Walkthrough

Walkthrough

iOS app configuration file updates the CFBundleURLName identifier from ee.forgr.capacitor_go to ee.forgr.capacitorgo, removing the underscore from the URL bundle scheme identifier.

Changes

iOS URL Bundle Identifier Update

Layer / File(s) Summary
CFBundleURLName identifier update
ios/App/App/Info.plist
CFBundleURLName string in the CFBundleURLTypes configuration is updated to remove the underscore separator, changing from ee.forgr.capacitor_go to ee.forgr.capacitorgo.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute


Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Jun 4, 2026

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing wolny/ios-fix-url-scheme (bad16ca) with main (7031192)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@WcaleNieWolny WcaleNieWolny merged commit b3c0596 into main Jun 4, 2026
38 of 39 checks passed
@WcaleNieWolny WcaleNieWolny deleted the wolny/ios-fix-url-scheme branch June 4, 2026 09:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant