Skip to content

[codex] fix proximity docs icon build#582

Merged
riderx merged 1 commit intomainfrom
codex/fix-proximity-icon
Apr 22, 2026
Merged

[codex] fix proximity docs icon build#582
riderx merged 1 commit intomainfrom
codex/fix-proximity-icon

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Apr 22, 2026

What changed

  • added the missing proximity.svg source asset under apps/web/public/icons/plugins/ so the docs asset sync can copy it
  • switched the proximity docs hero image reference to the standard ~public/icons/plugins/... format Astro expects

Why

The docs build deletes and rebuilds apps/docs/public from apps/web/public. The proximity icon only existed in docs public, and the docs frontmatter used /icons/... instead of the supported ~public/... form, so the build could not resolve the image.

Validation

  • bun run build:docs

Summary by CodeRabbit

Documentation

  • Updated the proximity plugin documentation page to ensure the plugin icon displays correctly in the header.

@riderx riderx marked this pull request as ready for review April 22, 2026 13:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1674076f-1b60-405b-b4e2-17a781ef1a4a

📥 Commits

Reviewing files that changed from the base of the PR and between e8a78e0 and b63264e.

⛔ Files ignored due to path filters (1)
  • apps/web/public/icons/plugins/proximity.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • apps/docs/src/content/docs/docs/plugins/proximity/index.mdx

📝 Walkthrough

Walkthrough

Updated the hero image asset path in the Proximity plugin documentation from /icons/plugins/proximity.svg to ~public/icons/plugins/proximity.svg, adjusting the icon reference to use a public directory path pattern.

Changes

Cohort / File(s) Summary
Documentation Asset Path
apps/docs/src/content/docs/docs/plugins/proximity/index.mdx
Updated hero image path in frontmatter from /icons/plugins/proximity.svg to ~public/icons/plugins/proximity.svg for proper asset resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A path through the woods, once tangled and long,
Now straightened with tildes, where icons belong—
From root to the public, the assets now bound,
This little hop forward keeps all of us sound! 🎯

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[codex] fix proximity docs icon build' directly addresses the main change: fixing the proximity documentation icon asset path resolution in the build process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-proximity-icon

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@riderx riderx merged commit 96786f3 into main Apr 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant