fix: parse signer_id from sign URL fragment#20
Merged
Conversation
Universign now returns the signing URL with the signer id in the fragment
("https://app.universign.com/sig/#/?id=...") instead of the query string.
URI#query was nil for these URLs, so Transaction#signer_id returned nil and
callers could not identify the signer. Read the id from the query or the
fragment so both legacy and app.universign.com URLs are supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Universign renvoie désormais l'URL de signature avec l'
iddu signataire dans le fragment (https://app.universign.com/sig/#/?id=...) et non plus dans la query string.Transaction#signer_idlisait uniquementURI(sign_url).query, qui estnilpour ces URLs →signer_idrenvoyaitnil. Les consommateurs (ex. Swissroc) ne pouvaient plus identifier le signataire : le flux de signature restait bloqué silencieusement (aucune exception levée).Correctif
signer_idlit l'iddepuis la query OU le fragment, ce qui couvre les URLs legacy (.../signature/?id=...) et app.universign.com (.../sig/#/?id=...).Tests
app.universign.com(id dans le fragment).