Skip to content

chore: remove solid motion one#1150

Merged
ameer2468 merged 1 commit intomainfrom
use-css-transitions
Oct 7, 2025
Merged

chore: remove solid motion one#1150
ameer2468 merged 1 commit intomainfrom
use-css-transitions

Conversation

@ameer2468
Copy link
Copy Markdown
Contributor

@ameer2468 ameer2468 commented Oct 7, 2025

Replace motion one with css transitions.

Summary by CodeRabbit

  • Refactor

    • Updated UI animations for target selection and grid items to a unified transition approach, delivering smoother, consistent enter/exit effects with subtle staggered delays. Interactive behavior remains unchanged.
  • Chores

    • Removed an unused animation dependency from the desktop app to simplify the build and slightly reduce the application footprint.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced Motion-based animations with solid-transition-group Transitions in TargetSelectionHome and TargetMenuGrid. Introduced enter/exit class-based animations with per-item delays. Removed the solid-motionone dependency from apps/desktop/package.json. No changes to exports or public APIs.

Changes

Cohort / File(s) Summary
Dependency cleanup
apps/desktop/package.json
Removed solid-motionone from dependencies. No replacement added.
Animation refactor: Target menu/grid
apps/desktop/src/routes/(window-chrome)/new-main/TargetMenuGrid.tsx
Replaced Motion wrappers with Transition from solid-transition-group. Added appear/enter/exit classes and per-item transition-delay via an inner div around TargetCard. Structure adjusted accordingly.
Animation refactor: Target selection home
apps/desktop/src/routes/(window-chrome)/new-main/index.tsx
Replaced Motion wrapper with Transition. Reorganized markup to fit class-based enter/exit animations. Maintained functional logic for selecting display/window/area targets.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant App
  participant TargetSelectionHome
  participant Transition as Transition (solid-transition-group)
  participant TargetMenuGrid
  participant TargetCard

  App->>TargetSelectionHome: Render
  TargetSelectionHome->>Transition: Mount with appear + enter/exit classes
  Note right of Transition: Applies CSS-based enter animation
  Transition->>TargetMenuGrid: Show selected grid
  loop For each item
    TargetMenuGrid->>Transition: Wrap item with enter/exit
    Note over TargetMenuGrid,TargetCard: Inline per-item transition-delay (100ms increments)
    Transition->>TargetCard: Render
  end
  App-->>Transition: Unmount/Toggle
  Note right of Transition: Triggers exit classes for smooth removal
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit hops through UI light,
Swapping Motion for Transitions bright.
With gentle fades and timed delay,
Each card arrives—then slips away.
Dependencies trimmed, the path is clear,
Soft steps of CSS you barely hear. 🐇✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-css-transitions

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80d1983 and d9c635b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • apps/desktop/package.json (0 hunks)
  • apps/desktop/src/routes/(window-chrome)/new-main/TargetMenuGrid.tsx (3 hunks)
  • apps/desktop/src/routes/(window-chrome)/new-main/index.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ameer2468 ameer2468 merged commit 00a7d88 into main Oct 7, 2025
13 of 15 checks passed
@ameer2468 ameer2468 deleted the use-css-transitions branch October 7, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant