feat(desktop): add timeline slider to crop modal for frame-accurate cropping #1451
Conversation
…ropping Previously, the crop modal only showed the first frame of the video (a static screenshot). I couldn't crop based on content that appeared later in the recording, and I had to guess the crop and go back to the main timeline to check. This change adds a timeline slider to the crop modal, allowing users to scrub through the entire video and select any frame as their cropping reference. ## What's New - **Timeline slider** below the crop preview with current time and total duration - **Instant video scrubbing** using native <video> element with hardware-accelerated seeking - **Preload strategy** where video metadata preloads on editor open, and full video preloads on Crop button hover/focus for instant display - **Loading indicator** that shows a "Loading" pill while video buffers - **Smooth crossfade** with a 150ms transition from screenshot to video - **Screenshot fallback** that gracefully degrades if video fails to load ## Technical Notes - Uses raw source video (display.mp4) for scrubbing, not the rendered output with effects. This is intentional as crop applies to the background layer, and effects render on top. - Video is positioned absolute with object-contain to prevent layout shift while maintaining aspect ratio. ## Files Changed - [apps/desktop/src/routes/editor/Editor.tsx](cci:7://file:///Users/MAC/Desktop/Desktop%20-%20Poe%27s%20MacBook%20Pro/Engineering/Open%20Source/Cap/apps/desktop/src/routes/editor/Editor.tsx:0:0-0:0) - crop dialogue with video, slider, loading indicator - [apps/desktop/src/routes/editor/Player.tsx](cci:7://file:///Users/MAC/Desktop/Desktop%20-%20Poe%27s%20MacBook%20Pro/Engineering/Open%20Source/Cap/apps/desktop/src/routes/editor/Player.tsx:0:0-0:0) - preload on Crop button hover/focus - [apps/desktop/src/routes/editor/context.ts](cci:7://file:///Users/MAC/Desktop/Desktop%20-%20Poe%27s%20MacBook%20Pro/Engineering/Open%20Source/Cap/apps/desktop/src/routes/editor/context.ts:0:0-0:0) - preload metadata on editor mount - [apps/desktop/src/routes/editor/cropVideoPreloader.ts](cci:7://file:///Users/MAC/Desktop/Desktop%20-%20Poe%27s%20MacBook%20Pro/Engineering/Open%20Source/Cap/apps/desktop/src/routes/editor/cropVideoPreloader.ts:0:0-0:0) - new preload manager module ## How to Test 1. Open a recording in the editor 2. Hover over the "Crop" button (triggers video preload) 3. Click "Crop" to open the modal 4. Verify: - Loading indicator appears briefly (if video not yet cached) - Smooth crossfade from screenshot to video - Slider shows current time (left) and total duration (right) - Dragging slider updates video frame instantly - Crop bounds can be adjusted at any frame - Clicking "Save" persists the crop correctly
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRefactors desktop routing to a nested, lazy Route tree; adds editor video preloading and an in-crop live preview with slider; expands startup/setup permission checks to include microphone and camera and flips a recording-flow default; updates Vite optimizeDeps and typings; and simplifies a benchmark loop. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Entry as entry-client.tsx
participant App as App.tsx
participant Startup as src-tauri/lib.rs
participant Router
participant Setup as setup.tsx
participant Editor as editor/context.ts
participant Preloader as cropVideoPreloader.ts
User->>Entry: launch app
Entry->>Entry: initApp() (dynamic OS import)
Entry->>App: mount app
App->>Startup: check permissions (screen, accessibility, microphone, camera)
alt all permissions granted
Startup->>Router: open Main window
else missing perms
Startup->>Router: open Setup
Router->>Setup: show mic & camera prompts
User->>Setup: grant perms
Setup->>Router: open Main window
end
User->>Router: navigate to /editor
Router->>Editor: initialize editor/context
Editor->>Preloader: preloadCropVideoMetadata(segment-0)
User->>Editor: hover/focus Crop button
Editor->>Preloader: preloadCropVideoFull()
User->>Editor: click Crop -> show cropper with video + slider
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Files/areas needing extra attention:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (6)**/*.ts📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/desktop/**/*.ts📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx,rs}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.tsx📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📓 Common learnings🧬 Code graph analysis (1)apps/desktop/src/routes/editor/Editor.tsx (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (4)
crates/frame-converter/examples/benchmark.rs (1)
68-75: Handle the Option return value from recv_timeout.Line 69 uses
let _ =to discard the Option returned byrecv_timeout, which violates the coding guideline requiring all Option/Result types to be handled. While the intent—draining the output channel to prevent backpressure—is clear, the return value should be handled explicitly.Consider one of these approaches:
while Instant::now() < deadline { - let _ = pool.recv_timeout(Duration::from_millis(100)); + let _ = pool.recv_timeout(Duration::from_millis(100)).is_some(); let stats = pool.stats();Or make the intent explicit by consuming the value:
while Instant::now() < deadline { - let _ = pool.recv_timeout(Duration::from_millis(100)); + while pool.try_recv().is_some() {} + std::thread::sleep(Duration::from_millis(100)); let stats = pool.stats();Based on coding guidelines: "Always handle Result/Option or types marked #[must_use]; never ignore them"
apps/desktop/src/routes/editor/cropVideoPreloader.ts (2)
7-17: Missing error handler for video load failure.If the video fails to load during metadata preload,
preloadStatewill remain stuck at"metadata", preventing any retry or fallback behavior. Consider adding anonerrorhandler to reset state on failure.export function preloadCropVideoMetadata(videoPath: string) { if (preloadState !== "idle") return; currentVideoPath = videoPath; preloadedVideo = document.createElement("video"); preloadedVideo.preload = "metadata"; preloadedVideo.src = convertFileSrc(videoPath); preloadedVideo.muted = true; + preloadedVideo.onerror = () => { + preloadState = "idle"; + currentVideoPath = null; + preloadedVideo = null; + }; preloadedVideo.load(); preloadState = "metadata"; }
19-30: Add error handler for full preload as well.Similarly, if the full preload fails, the state will be stuck at
"full". Reset state on error for consistent behavior.export function preloadCropVideoFull() { if (!preloadedVideo || preloadState === "full" || preloadState === "ready") return; preloadedVideo.preload = "auto"; preloadedVideo.load(); preloadState = "full"; preloadedVideo.oncanplaythrough = () => { preloadState = "ready"; }; + preloadedVideo.onerror = () => { + preloadState = "idle"; + currentVideoPath = null; + preloadedVideo = null; + }; }apps/desktop/src/routes/editor/Editor.tsx (1)
459-469: Consider resettingvideoLoadedwhen segment changes.When
videoSrcchanges (user scrubs to a different segment), the video reloads butvideoLoadedremainstrue, so the loading indicator won't appear during segment transitions. If this causes noticeable stalls without feedback, consider resetting the state.+createEffect( + on(videoSrc, () => { + setVideoLoaded(false); + }) +); createEffect(() => { if (videoRef && videoLoaded()) { videoRef.currentTime = currentSegment().localTime; } });
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
.gitignore(1 hunks)apps/desktop/app.config.ts(1 hunks)apps/desktop/src-tauri/src/general_settings.rs(2 hunks)apps/desktop/src-tauri/src/lib.rs(1 hunks)apps/desktop/src/App.tsx(6 hunks)apps/desktop/src/entry-client.tsx(1 hunks)apps/desktop/src/routes/(window-chrome).tsx(2 hunks)apps/desktop/src/routes/(window-chrome)/setup.tsx(2 hunks)apps/desktop/src/routes/editor/Editor.tsx(3 hunks)apps/desktop/src/routes/editor/Player.tsx(2 hunks)apps/desktop/src/routes/editor/context.ts(2 hunks)apps/desktop/src/routes/editor/cropVideoPreloader.ts(1 hunks)crates/frame-converter/examples/benchmark.rs(1 hunks)packages/ui-solid/src/auto-imports.d.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (8)
**/*.tsx
📄 CodeRabbit inference engine (CLAUDE.md)
Use React Query hooks with Server Actions for mutations and perform precise cache updates using setQueryData/setQueriesData instead of broad invalidations
Files:
apps/desktop/src/entry-client.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/src/routes/(window-chrome)/setup.tsxapps/desktop/src/routes/editor/Player.tsxapps/desktop/src/App.tsxapps/desktop/src/routes/editor/Editor.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use strict TypeScript; avoid any type; leverage shared types from @cap/* packages
Follow camelCase naming for variables and functions; PascalCase for components; hooks must start with 'use' prefix
Use Biome for linting and formatting; match existing formatting conventions in the codebase
Use Tailwind CSS for styling in web components; stay consistent with spacing and tokens
Use static skeletons for loading states that mirror content; avoid bouncing animations
Memoize expensive work, code-split naturally, and use Next/Image for remote assets
**/*.{ts,tsx,js,jsx}: Use 2-space indent for TypeScript files; format with Biome usingpnpm format
Use Biome for code formatting and linting; runpnpm formatregularly
Use kebab-case for file names (e.g.,user-menu.tsx); use PascalCase for components
Files:
apps/desktop/src/entry-client.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/app.config.tsapps/desktop/src/routes/(window-chrome)/setup.tsxpackages/ui-solid/src/auto-imports.d.tsapps/desktop/src/routes/editor/cropVideoPreloader.tsapps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/Player.tsxapps/desktop/src/App.tsxapps/desktop/src/routes/editor/Editor.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Never add any form of comments to code (single-line //, multi-line /* /, JSDoc /* */, or any other comment syntax); code must be self-explanatory through naming, types, and structure
Directory naming must use lowercase-dashed convention
Files:
apps/desktop/src/entry-client.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/app.config.tsapps/desktop/src/routes/(window-chrome)/setup.tsxpackages/ui-solid/src/auto-imports.d.tsapps/desktop/src/routes/editor/cropVideoPreloader.tsapps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/Player.tsxapps/desktop/src/App.tsxapps/desktop/src/routes/editor/Editor.tsx
**/*.{ts,tsx,js,jsx,rs}
📄 CodeRabbit inference engine (AGENTS.md)
Never add comments to code (
//,/* */,///,//!,#, etc.); code must be self-explanatory through naming, types, and structure
Files:
apps/desktop/src/entry-client.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/app.config.tscrates/frame-converter/examples/benchmark.rsapps/desktop/src/routes/(window-chrome)/setup.tsxapps/desktop/src-tauri/src/lib.rspackages/ui-solid/src/auto-imports.d.tsapps/desktop/src-tauri/src/general_settings.rsapps/desktop/src/routes/editor/cropVideoPreloader.tsapps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/Player.tsxapps/desktop/src/App.tsxapps/desktop/src/routes/editor/Editor.tsx
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use TanStack Query v5 for all client-side server state and data fetching in TypeScript files
Files:
apps/desktop/app.config.tspackages/ui-solid/src/auto-imports.d.tsapps/desktop/src/routes/editor/cropVideoPreloader.tsapps/desktop/src/routes/editor/context.ts
**/*.config.{js,ts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Configuration files must follow their respective tool conventions (Next.js, Tailwind, etc.)
Files:
apps/desktop/app.config.ts
apps/desktop/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
apps/desktop/**/*.ts: Use @tanstack/solid-query for server state management in SolidJS components
Use generated commands and events from tauri_specta for IPC; never manually construct IPC calls
Listen directly to generated events from tauri_specta and use typed event interfaces
Files:
apps/desktop/app.config.tsapps/desktop/src/routes/editor/cropVideoPreloader.tsapps/desktop/src/routes/editor/context.ts
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.rs: Never use dbg!() macro; use proper logging (tracing::debug!, etc.) instead
Never write let _ = async_fn() which silently drops futures; await or explicitly handle them
Use duration.saturating_sub(other) instead of duration - other to avoid panics on underflow
Merge nested if statements: write 'if a && b { }' instead of 'if a { if b { } }'
Don't call .clone() on Copy types (integers, bools, etc.); copy them directly
Use function references directly: iter.map(foo) instead of iter.map(|x| foo(x))
Accept &[T] or &str instead of &Vec or &String in function parameters for flexibility
Use .is_empty() instead of .len() == 0 or .len() > 0 / .len() != 0
Don't assign () to a variable: write foo(); instead of let _ = foo(); or let x = foo(); when return is unit
Use .unwrap_or(val) instead of .unwrap_or_else(|| val) when the default is a simple/cheap value
Use 'for item in &collection' or 'for (i, item) in collection.iter().enumerate()' instead of 'for i in 0..collection.len()'
Use value.clamp(min, max) instead of manual if chains or .min(max).max(min) patterns
Always handle Result/Option or types marked #[must_use]; never ignore them
**/*.rs: Userustfmtand workspace clippy lints for Rust code formatting and linting
Use snake_case for Rust module names and kebab-case for crate names
Never usedbg!()macro in Rust code; use proper logging instead (Clippy:dbg_macro= deny)
Always handleResult/Optionor types marked#[must_use]; never ignore them (Rust compiler lint:unused_must_use= deny)
Never writelet _ = async_fn()which silently drops futures; await or explicitly handle them (Clippy:let_underscore_future= deny)
Usesaturating_subinstead of-forDurationto avoid panics (Clippy:unchecked_duration_subtraction= deny)
Merge nestedifstatements: useif a && b { }instead ofif a { if b { } }(Clippy:collapsible_if= deny)
Don't call.clone()onCopytypes; just copy them directly (Clippy:clone_on_copy= deny)
U...
Files:
crates/frame-converter/examples/benchmark.rsapps/desktop/src-tauri/src/lib.rsapps/desktop/src-tauri/src/general_settings.rs
🧠 Learnings (4)
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/web/**/*.tsx : Prefer Server Components for initial data fetching and SEO; pass initialData to client components and let React Query take over
Applied to files:
apps/desktop/src/entry-client.tsxapps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/desktop/**/*.ts : Use tanstack/solid-query for server state management in SolidJS components
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/web/**/*.tsx : Minimize useEffect usage in React components; compute during render, handle logic in event handlers, and ensure cleanups for subscriptions/timers
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:40.743Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-07T14:29:40.743Z
Learning: Applies to apps/web/**/*.{ts,tsx} : Use `useEffectQuery`/`useEffectMutation` from `@/lib/EffectRuntime` in client components; do not call `EffectRuntime.run*` directly
Applied to files:
apps/desktop/src/App.tsx
🧬 Code graph analysis (4)
crates/frame-converter/examples/benchmark.rs (1)
crates/frame-converter/src/pool.rs (1)
stats(218-225)
apps/desktop/src/routes/editor/context.ts (1)
apps/desktop/src/routes/editor/cropVideoPreloader.ts (1)
preloadCropVideoMetadata(7-17)
apps/desktop/src/routes/editor/Player.tsx (1)
apps/desktop/src/routes/editor/cropVideoPreloader.ts (1)
preloadCropVideoFull(19-30)
apps/desktop/src/routes/editor/Editor.tsx (3)
apps/desktop/src/routes/editor/utils.ts (1)
formatTime(1-13)apps/desktop/src/routes/editor/ui.tsx (1)
Slider(65-149)apps/desktop/src/routes/editor/context.ts (1)
FPS(56-56)
🔇 Additional comments (12)
.gitignore (1)
53-53: Verify the documentation directory ignore is intentional.The
.docs/pattern addition appears unrelated to the PR's primary objectives (crop modal timeline slider). Per the AI summary, there are no related documentation file changes indicated in this PR. Please confirm whether this is intentional cleanup or should be part of a separate PR.apps/desktop/app.config.ts (1)
40-55: LGTM!The
optimizeDeps.includeconfiguration appropriately pre-bundles the dependencies used across the lazy-loaded routes, improving development server cold start performance and aligning with the dynamic import pattern introduced inApp.tsx.apps/desktop/src-tauri/src/lib.rs (1)
2678-2698: LGTM!The startup flow now correctly gates on all four required permissions (screen recording, accessibility, microphone, and camera) before showing the main window, aligning with the expanded permission prompts in the setup UI.
apps/desktop/src/routes/(window-chrome)/setup.tsx (1)
42-52: LGTM!The Microphone and Camera permissions are correctly added with appropriate descriptions, aligning with the updated startup permission requirements in the Rust backend.
apps/desktop/src/routes/editor/Player.tsx (1)
261-262: LGTM!The preload triggers on
onMouseEnterandonFocusimplement the second stage of the two-stage preloading strategy effectively. The preloader module handles idempotency, so multiple trigger events won't cause redundant loads.apps/desktop/src/routes/editor/context.ts (1)
756-758: Verify path assumption for multi-segment recordings.The preload path hardcodes
segment-0, which should work for single-segment recordings. For multi-segment recordings, confirm thatsegment-0/display.mp4is always the appropriate video for the crop preview, or consider using the first segment frominstance.recordings.segments[0]if available.apps/desktop/src/entry-client.tsx (1)
4-16: LGTM!The refactor to async initialization with dynamic import is well-structured. Error handling gracefully falls back to mounting without the platform class, and the dynamic import pattern aligns with the broader code-splitting strategy in this PR.
apps/desktop/src/App.tsx (2)
21-74: LGTM!The lazy-loaded route components are well-organized with clear naming conventions. This code-splitting approach will improve initial load time by deferring the loading of route components until they're needed.
220-268: LGTM on the routing structure.The explicit Route tree with nested layouts provides clear route organization:
- Settings routes correctly nested under
SettingsLayout- Window chrome routes grouped under
WindowChromeLayout- Standalone routes (camera, capture-area, etc.) appropriately placed outside the chrome layout
This gives better control over route configuration than the previous FileRoutes approach.
apps/desktop/src/routes/editor/cropVideoPreloader.ts (1)
32-47: LGTM!The getter functions and cleanup are straightforward and properly reset all module state.
apps/desktop/src/routes/editor/Editor.tsx (2)
631-684: LGTM!The video overlay with crossfade transitions, loading indicator, and timeline slider are well-implemented. The
aria-labelon the slider and frame-accurate step (1 / FPS) are good details.
425-431: LGTM!Appropriate expansion of context destructuring to support the new video playback and timeline functionality.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/desktop/src/routes/editor/Editor.tsx (1)
459-469: Consider resettingvideoLoadedwhen video source changes.When scrubbing across segment boundaries,
videoSrc()changes butvideoLoadedremainstrueuntil the new video loads. This could briefly show a stale frame. Consider resetting the state when the segment changes:+ createEffect( + on( + () => currentSegment().index, + () => setVideoLoaded(false), + { defer: true }, + ), + ); + createEffect(() => { if (videoRef && videoLoaded()) { videoRef.currentTime = currentSegment().localTime; } });
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
apps/desktop/src-tauri/src/general_settings.rs(2 hunks)apps/desktop/src/App.tsx(3 hunks)apps/desktop/src/routes/(window-chrome).tsx(1 hunks)apps/desktop/src/routes/(window-chrome)/setup.tsx(2 hunks)apps/desktop/src/routes/editor/Editor.tsx(3 hunks)apps/desktop/src/routes/editor/context.ts(2 hunks)packages/ui-solid/src/auto-imports.d.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/desktop/src/routes/editor/context.ts
- apps/desktop/src/routes/(window-chrome)/setup.tsx
🧰 Additional context used
📓 Path-based instructions (6)
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.rs: Never use dbg!() macro; use proper logging (tracing::debug!, etc.) instead
Never write let _ = async_fn() which silently drops futures; await or explicitly handle them
Use duration.saturating_sub(other) instead of duration - other to avoid panics on underflow
Merge nested if statements: write 'if a && b { }' instead of 'if a { if b { } }'
Don't call .clone() on Copy types (integers, bools, etc.); copy them directly
Use function references directly: iter.map(foo) instead of iter.map(|x| foo(x))
Accept &[T] or &str instead of &Vec or &String in function parameters for flexibility
Use .is_empty() instead of .len() == 0 or .len() > 0 / .len() != 0
Don't assign () to a variable: write foo(); instead of let _ = foo(); or let x = foo(); when return is unit
Use .unwrap_or(val) instead of .unwrap_or_else(|| val) when the default is a simple/cheap value
Use 'for item in &collection' or 'for (i, item) in collection.iter().enumerate()' instead of 'for i in 0..collection.len()'
Use value.clamp(min, max) instead of manual if chains or .min(max).max(min) patterns
Always handle Result/Option or types marked #[must_use]; never ignore them
**/*.rs: Userustfmtand workspace clippy lints for Rust code formatting and linting
Use snake_case for Rust module names and kebab-case for crate names
Never usedbg!()macro in Rust code; use proper logging instead (Clippy:dbg_macro= deny)
Always handleResult/Optionor types marked#[must_use]; never ignore them (Rust compiler lint:unused_must_use= deny)
Never writelet _ = async_fn()which silently drops futures; await or explicitly handle them (Clippy:let_underscore_future= deny)
Usesaturating_subinstead of-forDurationto avoid panics (Clippy:unchecked_duration_subtraction= deny)
Merge nestedifstatements: useif a && b { }instead ofif a { if b { } }(Clippy:collapsible_if= deny)
Don't call.clone()onCopytypes; just copy them directly (Clippy:clone_on_copy= deny)
U...
Files:
apps/desktop/src-tauri/src/general_settings.rs
**/*.{ts,tsx,js,jsx,rs}
📄 CodeRabbit inference engine (AGENTS.md)
Never add comments to code (
//,/* */,///,//!,#, etc.); code must be self-explanatory through naming, types, and structure
Files:
apps/desktop/src-tauri/src/general_settings.rsapps/desktop/src/routes/editor/Editor.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/src/App.tsxpackages/ui-solid/src/auto-imports.d.ts
**/*.tsx
📄 CodeRabbit inference engine (CLAUDE.md)
Use React Query hooks with Server Actions for mutations and perform precise cache updates using setQueryData/setQueriesData instead of broad invalidations
Files:
apps/desktop/src/routes/editor/Editor.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/src/App.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use strict TypeScript; avoid any type; leverage shared types from @cap/* packages
Follow camelCase naming for variables and functions; PascalCase for components; hooks must start with 'use' prefix
Use Biome for linting and formatting; match existing formatting conventions in the codebase
Use Tailwind CSS for styling in web components; stay consistent with spacing and tokens
Use static skeletons for loading states that mirror content; avoid bouncing animations
Memoize expensive work, code-split naturally, and use Next/Image for remote assets
**/*.{ts,tsx,js,jsx}: Use 2-space indent for TypeScript files; format with Biome usingpnpm format
Use Biome for code formatting and linting; runpnpm formatregularly
Use kebab-case for file names (e.g.,user-menu.tsx); use PascalCase for components
Files:
apps/desktop/src/routes/editor/Editor.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/src/App.tsxpackages/ui-solid/src/auto-imports.d.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Never add any form of comments to code (single-line //, multi-line /* /, JSDoc /* */, or any other comment syntax); code must be self-explanatory through naming, types, and structure
Directory naming must use lowercase-dashed convention
Files:
apps/desktop/src/routes/editor/Editor.tsxapps/desktop/src/routes/(window-chrome).tsxapps/desktop/src/App.tsxpackages/ui-solid/src/auto-imports.d.ts
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use TanStack Query v5 for all client-side server state and data fetching in TypeScript files
Files:
packages/ui-solid/src/auto-imports.d.ts
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Memoize expensive work, code-split naturally, and use Next/Image for remote assets
📚 Learning: 2025-12-07T14:29:40.743Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-07T14:29:40.743Z
Learning: Applies to **/tauri.ts|**/queries.ts|apps/desktop/src-tauri/gen/** : Never edit auto-generated files: `**/tauri.ts`, `**/queries.ts`, `apps/desktop/src-tauri/gen/**`
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/desktop/**/*.ts : Use tanstack/solid-query for server state management in SolidJS components
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/web/**/*.tsx : Prefer Server Components for initial data fetching and SEO; pass initialData to client components and let React Query take over
Applied to files:
apps/desktop/src/App.tsx
🧬 Code graph analysis (2)
apps/desktop/src/routes/editor/Editor.tsx (3)
apps/desktop/src/routes/editor/utils.ts (1)
formatTime(1-13)apps/desktop/src/routes/editor/ui.tsx (1)
Slider(65-149)apps/desktop/src/routes/editor/context.ts (1)
FPS(56-56)
apps/desktop/src/routes/(window-chrome).tsx (1)
apps/desktop/src/components/Loader.tsx (1)
AbsoluteInsetLoader(1-9)
🔇 Additional comments (8)
packages/ui-solid/src/auto-imports.d.ts (1)
85-85: No action needed—the import path is correct.The Lucide icon library includes a
loader-2icon, and the current code properly uses the kebab-case import pathloader-2.jsx, which is consistent with Lucide's naming convention and all other icons in this file.apps/desktop/src-tauri/src/general_settings.rs (1)
136-138: Logic is now consistent and clearer.The default for
enable_new_recording_flowis nowfalse, and the initialization logic only sets it tofalsefor users who haven't set their picker preference yet. This is a cleaner approach than the previous implementation that had an unconditional reset.Also applies to: 261-264
apps/desktop/src/routes/(window-chrome).tsx (1)
41-48: Simplified Suspense fallbacks look good.The fallback simplification removes unnecessary custom functions and logging. The inner Suspense without a fallback correctly prevents content flicker during route transitions.
apps/desktop/src/routes/editor/Editor.tsx (3)
443-457: Segment time calculation is now correct.The
localTimecalculation has been fixed to return seconds (seg.start / seg.timescale + (time - elapsed)), which is the correct unit forvideo.currentTime. This addresses the issue from the previous review.
631-664: Video/image composite with loading state is well implemented.The layered approach with crossfade transitions, loading indicator, and error fallback to the screenshot provides a good user experience. The
object-containclass correctly preserves aspect ratio.
668-684: Timeline slider implementation is solid.Frame-accurate seeking with
step={1 / FPS}, proper time formatting on both ends, and accessibility viaaria-labelall align with the PR objectives.apps/desktop/src/App.tsx (2)
21-74: Lazy loading setup looks good.All page components are properly lazy-loaded, enabling code splitting. This aligns with the learning about memoizing expensive work and code-splitting naturally. Based on learnings.
145-173: Nested route structure with WindowChromeLayout is well-organized.The separation between chrome-wrapped routes (main, settings, etc.) and standalone routes (camera, editor, capture-area) is logical. Settings sub-routes are properly nested.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/desktop/src/routes/editor/cropVideoPreloader.ts (1)
7-22: Consider handling path changes when already preloading.If the editor navigates to a different recording while metadata is still loading, subsequent calls with a different
videoPathare silently ignored due to thepreloadState !== "idle"guard.Consider resetting state when a different path is requested:
export function preloadCropVideoMetadata(videoPath: string) { - if (preloadState !== "idle") return; + if (preloadState !== "idle") { + if (currentVideoPath === videoPath) return; + cleanup(); + } currentVideoPath = videoPath;
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/desktop/src/routes/editor/context.ts(4 hunks)apps/desktop/src/routes/editor/cropVideoPreloader.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use TanStack Query v5 for all client-side server state and data fetching in TypeScript files
Files:
apps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/cropVideoPreloader.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use strict TypeScript; avoid any type; leverage shared types from @cap/* packages
Follow camelCase naming for variables and functions; PascalCase for components; hooks must start with 'use' prefix
Use Biome for linting and formatting; match existing formatting conventions in the codebase
Use Tailwind CSS for styling in web components; stay consistent with spacing and tokens
Use static skeletons for loading states that mirror content; avoid bouncing animations
Memoize expensive work, code-split naturally, and use Next/Image for remote assets
**/*.{ts,tsx,js,jsx}: Use 2-space indent for TypeScript files; format with Biome usingpnpm format
Use Biome for code formatting and linting; runpnpm formatregularly
Use kebab-case for file names (e.g.,user-menu.tsx); use PascalCase for components
Files:
apps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/cropVideoPreloader.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Never add any form of comments to code (single-line //, multi-line /* /, JSDoc /* */, or any other comment syntax); code must be self-explanatory through naming, types, and structure
Directory naming must use lowercase-dashed convention
Files:
apps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/cropVideoPreloader.ts
apps/desktop/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
apps/desktop/**/*.ts: Use @tanstack/solid-query for server state management in SolidJS components
Use generated commands and events from tauri_specta for IPC; never manually construct IPC calls
Listen directly to generated events from tauri_specta and use typed event interfaces
Files:
apps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/cropVideoPreloader.ts
**/*.{ts,tsx,js,jsx,rs}
📄 CodeRabbit inference engine (AGENTS.md)
Never add comments to code (
//,/* */,///,//!,#, etc.); code must be self-explanatory through naming, types, and structure
Files:
apps/desktop/src/routes/editor/context.tsapps/desktop/src/routes/editor/cropVideoPreloader.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Memoize expensive work, code-split naturally, and use Next/Image for remote assets
🧬 Code graph analysis (1)
apps/desktop/src/routes/editor/context.ts (1)
apps/desktop/src/routes/editor/cropVideoPreloader.ts (1)
preloadCropVideoMetadata(7-22)
🔇 Additional comments (4)
apps/desktop/src/routes/editor/context.ts (1)
754-757: LGTM - Preload initialization looks correct.The preload call is appropriately placed after instance creation and before frame rendering setup. The path construction aligns with the segment directory structure.
apps/desktop/src/routes/editor/cropVideoPreloader.ts (3)
3-5: Module-level singleton state is appropriate for this use case.The singleton pattern works well here since only one crop modal can be open at a time. Consumers will need to poll
getPreloadState()since the state isn't reactive.
24-40: LGTM - Full preload upgrade logic is correct.The guard conditions properly prevent redundant loads, and the state transitions from "metadata"/"full" to "ready" on
canplaythroughare appropriate for the preload strategy.
50-57: LGTM - Cleanup properly releases resources.Setting
src = ""releases network resources. Since the video is always muted, explicitly callingpause()isn't necessary here.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/desktop/src/App.tsx (1)
209-212: Remove debug console.log.The console logging statement in the suspense fallback is debug code and should be removed before merging.
Apply this diff:
- fallback={ - (() => { - console.log("Root suspense fallback showing"); - }) as any - } + fallback={<></>}
♻️ Duplicate comments (1)
apps/desktop/src/App.tsx (1)
91-104: Remove debug telemetry code before merging.These debug fetch calls to localhost and the surrounding
// #region agent logcomments were already flagged in a previous review. The comments violate the coding guideline prohibiting any form of comments, and this debug instrumentation should not be merged to production.Also applies to: 115-128, 133-146, 176-198
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/desktop/src-tauri/src/lib.rs(1 hunks)apps/desktop/src/App.tsx(6 hunks)apps/desktop/src/routes/editor/Player.tsx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/desktop/src/routes/editor/Player.tsx
🧰 Additional context used
📓 Path-based instructions (5)
**/*.tsx
📄 CodeRabbit inference engine (CLAUDE.md)
Use React Query hooks with Server Actions for mutations and perform precise cache updates using setQueryData/setQueriesData instead of broad invalidations
Files:
apps/desktop/src/App.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use strict TypeScript; avoid any type; leverage shared types from @cap/* packages
Follow camelCase naming for variables and functions; PascalCase for components; hooks must start with 'use' prefix
Use Biome for linting and formatting; match existing formatting conventions in the codebase
Use Tailwind CSS for styling in web components; stay consistent with spacing and tokens
Use static skeletons for loading states that mirror content; avoid bouncing animations
Memoize expensive work, code-split naturally, and use Next/Image for remote assets
**/*.{ts,tsx,js,jsx}: Use 2-space indent for TypeScript files; format with Biome usingpnpm format
Use Biome for code formatting and linting; runpnpm formatregularly
Use kebab-case for file names (e.g.,user-menu.tsx); use PascalCase for components
Files:
apps/desktop/src/App.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Never add any form of comments to code (single-line //, multi-line /* /, JSDoc /* */, or any other comment syntax); code must be self-explanatory through naming, types, and structure
Directory naming must use lowercase-dashed convention
Files:
apps/desktop/src/App.tsx
**/*.{ts,tsx,js,jsx,rs}
📄 CodeRabbit inference engine (AGENTS.md)
Never add comments to code (
//,/* */,///,//!,#, etc.); code must be self-explanatory through naming, types, and structure
Files:
apps/desktop/src/App.tsxapps/desktop/src-tauri/src/lib.rs
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.rs: Never use dbg!() macro; use proper logging (tracing::debug!, etc.) instead
Never write let _ = async_fn() which silently drops futures; await or explicitly handle them
Use duration.saturating_sub(other) instead of duration - other to avoid panics on underflow
Merge nested if statements: write 'if a && b { }' instead of 'if a { if b { } }'
Don't call .clone() on Copy types (integers, bools, etc.); copy them directly
Use function references directly: iter.map(foo) instead of iter.map(|x| foo(x))
Accept &[T] or &str instead of &Vec or &String in function parameters for flexibility
Use .is_empty() instead of .len() == 0 or .len() > 0 / .len() != 0
Don't assign () to a variable: write foo(); instead of let _ = foo(); or let x = foo(); when return is unit
Use .unwrap_or(val) instead of .unwrap_or_else(|| val) when the default is a simple/cheap value
Use 'for item in &collection' or 'for (i, item) in collection.iter().enumerate()' instead of 'for i in 0..collection.len()'
Use value.clamp(min, max) instead of manual if chains or .min(max).max(min) patterns
Always handle Result/Option or types marked #[must_use]; never ignore them
**/*.rs: Userustfmtand workspace clippy lints for Rust code formatting and linting
Use snake_case for Rust module names and kebab-case for crate names
Never usedbg!()macro in Rust code; use proper logging instead (Clippy:dbg_macro= deny)
Always handleResult/Optionor types marked#[must_use]; never ignore them (Rust compiler lint:unused_must_use= deny)
Never writelet _ = async_fn()which silently drops futures; await or explicitly handle them (Clippy:let_underscore_future= deny)
Usesaturating_subinstead of-forDurationto avoid panics (Clippy:unchecked_duration_subtraction= deny)
Merge nestedifstatements: useif a && b { }instead ofif a { if b { } }(Clippy:collapsible_if= deny)
Don't call.clone()onCopytypes; just copy them directly (Clippy:clone_on_copy= deny)
U...
Files:
apps/desktop/src-tauri/src/lib.rs
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Memoize expensive work, code-split naturally, and use Next/Image for remote assets
📚 Learning: 2025-12-07T14:29:40.743Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-07T14:29:40.743Z
Learning: Applies to **/tauri.ts|**/queries.ts|apps/desktop/src-tauri/gen/** : Never edit auto-generated files: `**/tauri.ts`, `**/queries.ts`, `apps/desktop/src-tauri/gen/**`
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/desktop/**/*.ts : Use tanstack/solid-query for server state management in SolidJS components
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/web/**/*.tsx : Prefer Server Components for initial data fetching and SEO; pass initialData to client components and let React Query take over
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:19.180Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-07T14:29:19.180Z
Learning: Applies to apps/web/**/*.tsx : Minimize useEffect usage in React components; compute during render, handle logic in event handlers, and ensure cleanups for subscriptions/timers
Applied to files:
apps/desktop/src/App.tsx
📚 Learning: 2025-12-07T14:29:40.743Z
Learnt from: CR
Repo: CapSoftware/Cap PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-07T14:29:40.743Z
Learning: Applies to apps/web/**/*.{ts,tsx} : Use `useEffectQuery`/`useEffectMutation` from `@/lib/EffectRuntime` in client components; do not call `EffectRuntime.run*` directly
Applied to files:
apps/desktop/src/App.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (2)
apps/desktop/src/App.tsx (2)
1-1: LGTM! Well-structured lazy loading.The addition of explicit
Routeimports and extensive lazy-loaded page components aligns with best practices for code-splitting and improves initial load performance. The lazy loading pattern is correctly applied across all route components.Also applies to: 8-8, 21-74
219-267: LGTM! Clean route structure.The explicit Route tree is well-organized with appropriate nesting. The WindowChromeLayout parent route provides consistent layout for main app routes, while utility routes (camera, editor, debug) remain standalone. The settings subroutes are properly nested, and all components correctly reference the lazy-loaded definitions.
| if !permissions.screen_recording.permitted() | ||
| || !permissions.accessibility.permitted() | ||
| || !permissions.microphone.permitted() | ||
| || !permissions.camera.permitted() |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Read context around lines 2700-2703 to understand the permission flow
sed -n '2685,2730p' apps/desktop/src-tauri/src/lib.rsRepository: CapSoftware/Cap
Length of output: 1862
🏁 Script executed:
# Find where the permissions check is implemented
rg "fn do_permissions_check" --max-count 5 -B 2 -A 20Repository: CapSoftware/Cap
Length of output: 2006
🏁 Script executed:
# Find the OSPermissionsCheck struct and its permitted() method
rg "struct OSPermissionsCheck|fn permitted" --max-count 10 -B 2 -A 5Repository: CapSoftware/Cap
Length of output: 1107
🏁 Script executed:
# Look for the Setup window implementation to see if it's skippable
rg "ShowCapWindow::Setup" --max-count 10 -B 5 -A 10Repository: CapSoftware/Cap
Length of output: 2610
🏁 Script executed:
# Look for the Setup window file or implementation
fd "setup" --type f --extension tsx --extension ts --extension rs | head -20Repository: CapSoftware/Cap
Length of output: 265
🏁 Script executed:
# Read the setup window implementation
cat -n apps/desktop/src/routes/\(window-chrome\)/setup.tsx | head -100Repository: CapSoftware/Cap
Length of output: 3350
🏁 Script executed:
# Continue reading the setup window implementation
sed -n '100,250p' apps/desktop/src/routes/\(window-chrome\)/setup.tsxRepository: CapSoftware/Cap
Length of output: 4244
Confirm that mandatory microphone and camera permissions at startup align with product goals.
The Setup window requires users to grant all four permissions (screen recording, accessibility, microphone, and camera) before accessing the main application. The "Continue" button is disabled until every permission shows as granted or not needed. Users cannot proceed without granting all permissions, even if they only intend to use screen recording features.
While the PR indicates this expansion is intentional, verify with product/design that forcing microphone and camera grants at initial onboarding is the desired UX pattern. This creates a hard gate on features that users may not need, potentially causing drop-off during onboarding. If these permissions are truly optional features, consider deferring their requests until users attempt to use those specific features.
🤖 Prompt for AI Agents
In apps/desktop/src-tauri/src/lib.rs around lines 2700-2703, the setup gating
logic requires microphone and camera permissions alongside screen recording and
accessibility before enabling Continue; confirm with product/design whether mic
and camera should be mandatory at onboarding, and if they are optional change
the gating logic to only require truly mandatory permissions (e.g., screen
recording and accessibility) and defer requesting mic/camera until the user
invokes features that need them; alternatively, if they must remain optional but
still shown, update the UI to indicate they are optional and allow Continue when
required permissions are granted, and implement lazy permission prompts where
mic/camera requests are triggered at feature use.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| elapsed += segDuration; | ||
| } | ||
| return { index: 0, localTime: 0 }; | ||
| }); |
There was a problem hiding this comment.
Bug: Slider at end position shows wrong frame
The currentSegment memo uses strict less-than comparison (time < elapsed + segDuration) which fails when the slider is at the maximum position. When previewTime() equals totalDuration(), the condition time < elapsed + segDuration evaluates to false for all segments, causing the fallback { index: 0, localTime: 0 } to be returned. This displays the first frame of the first segment instead of the last frame of the last segment when the user drags the timeline slider to the end.
|
Awesome work! |
|
Thanks! |
2 participants
Previously, the crop modal only showed the first frame of the video (a static
screenshot). I couldn't crop based on content that appeared later in the
recording, and I had to guess the crop and go back to the main timeline to check.
This change adds a timeline slider to the crop modal, allowing users to scrub
through the entire video and select any frame as their cropping reference.
What's New
Technical Notes
How to Test
Additional improvements since:
remove unconditional reset of enable_new_recording_flow
The flag was being reset to false on every app start, making the setting
unusable. Users can now toggle between old and new recording flow in settings.
remove debug telemetry fetch calls from App.tsx, (window-chrome).tsx,
and setup.tsx. Deleted all #region agent log blocks and hardcoded local
ingest endpoint calls.
remove debug console.log statements from context.ts and Suspense
fallbacks
correct IconLucideLoader2 import path to use kebab-case
(loader-2.jsx instead of loader2.jsx)
correct localTime calculation in currentSegment memo
Changed from
seg.start + (time - elapsed) * seg.timescaletoseg.start / seg.timescale + (time - elapsed)for proper time conversionSummary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.
Note
Adds a video-backed crop modal with a timeline slider and preloading for instant scrubbing, plus permission checks for mic/camera, lazy-loaded routing, and updated defaults.
Sliderfor frame-accurate cropping; adds loading indicator and smooth crossfade.routes/editor/cropVideoPreloader.tsand triggers full preload on Crop hover/focus.microphoneandcamerapermissions and surfaces them in the UI.enable_new_recording_flowdefault set tofalseand initialized when preference not set.FileRouteswith explicit, lazily-loadedRoutes for main/settings pages and overlays.entry-client.tsx: dynamically imports@tauri-apps/plugin-osbefore mount; ViteoptimizeDeps.includeupdated..docs/to.gitignore.IconLucideLoader2).benchmark.rsreceive loop cleanup.Written by Cursor Bugbot for commit 62110cc. This will update automatically on new commits. Configure here.