fix: prevent mask coverage gap during adjacent segment transitions#1631
Open
AdamJBurns wants to merge 2 commits intoCapSoftware:mainfrom
Open
fix: prevent mask coverage gap during adjacent segment transitions#1631AdamJBurns wants to merge 2 commits intoCapSoftware:mainfrom
AdamJBurns wants to merge 2 commits intoCapSoftware:mainfrom
Conversation
Prevents suppressing fades on segments that have an intentional gap. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two mask segments are directly adjacent (share a boundary) and a zoom is applied, the current interpolation logic can fade out/in at the shared edge. During the transition, opacity briefly drops at that boundary, exposing sensitive content.
All other behavior is unchanged: PreparedMask construction, clamping, feathering, and size handling remain identical.
Fixes: #1619
Greptile Summary
Prevents opacity gaps during adjacent mask segment transitions by detecting when segments share boundaries and skipping fade-in/fade-out at those points
<instead of<=may miss segments exactly atfade_durationapartConfidence Score: 4/5
<=instead of<to catch exact boundary matches atfade_durationdistanceImportant Files Changed
Last reviewed commit: 1354425
(2/5) Greptile learns from your feedback when you react with thumbs up/down!