Skip to content

fix: allow /embed/ and /.well-known/ routes on self-hosted instances #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bskthefirst wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: allow /embed/ and /.well-known/ routes on self-hosted instances #1802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/web/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ export async function proxy(request: NextRequest) {
path.startsWith("/invite") ||
path.startsWith("/self-hosting") ||
path.startsWith("/terms") ||
path.startsWith("/verify-otp")
path.startsWith("/verify-otp") ||
path.startsWith("/embed/") ||
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Trailing-slash mismatch on /embed/

The check uses path.startsWith("/embed/") (with a trailing slash), so a request to /embed (no trailing slash) would still be redirected to /login. All other "section" entries in this whitelist (e.g. /dashboard, /onboarding, /terms) omit the trailing slash and match both the root path and any sub-paths. To be consistent and safe, consider dropping the trailing slash so it reads path.startsWith("/embed").

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/web/proxy.ts
Line: 53

Comment:
**Trailing-slash mismatch on `/embed/`**

The check uses `path.startsWith("/embed/")` (with a trailing slash), so a request to `/embed` (no trailing slash) would still be redirected to `/login`. All other "section" entries in this whitelist (e.g. `/dashboard`, `/onboarding`, `/terms`) omit the trailing slash and match both the root path and any sub-paths. To be consistent and safe, consider dropping the trailing slash so it reads `path.startsWith("/embed")`.

How can I resolve this? If you propose a fix, please make it concise.

path.startsWith("/.well-known/")
) &&
process.env.NODE_ENV !== "development"
)
Expand Down