I want to add Korean localization.

[viola0081]

I want to add Korean localization.

I’ve already created the cardnames and .properties files, but I’m stuck on the next steps. I tested them by renaming the files to Japanese, but SourceHanSansJP causes the text to break. It works well if I switch to NotoSansKR-Medium.ttf, but even this font displays broken characters at low resolutions.

Since I don't know how to code, I'm not sure how to fix the font issue or what to do next. I would appreciate any help you can provide.

forge-kr.zip

[Hanmac]

We should probably look for another SourceHanSans font to keep them in theme?
like this one? https://fontmeme.com/fonts/source-han-sans-kr-font/

[Hanmac]

@viola0081 there is also this Class, see LandChinese:

forge/forge-core/src/main/java/forge/util/lang/LangChinese.java

Lines 7 to 15 in ebde173

	@Override
	public String getOrdinal(final int position) {
	return "第" + position;
	}
	@Override
	public String getPossesive(final String name) {
	return name + "的";
	}

Korean probably has something similar

[viola0081]

테마를 유지하려면 다른 SourceHanSans 폰트를 찾아보는 게 좋을 것 같네요. 이거 마음에 드세요? https://fontmeme.com/fonts/source-han-sans-kr-font/

Thank you for your help! I really like the font. However, I’m not sure if I applied it correctly, but after converting it to TTF, it works fine on the first run but fails to restart. It crashes at the "Loading fonts..." screen.

[viola0081]

@viola0081이 수업도 있습니다. LandChinese:

forge/forge-core/src/main/java/forge/util/lang/LangChinese.java

7행부터 15행까지 ~에 ebde173
@ 오버라이드
public String getOrdinal ( final int position ) {
return "제" + position ;
}

@ 오버라이드
public String getPossesive ( final String name ) {
반환합니다 이름 + " of"를 .
}

한국에도 비슷한 게 있을 것 같아요.

package forge.util.lang;

import forge.util.Lang;

public class LangKorean extends Lang {

    @Override
    public String getOrdinal(final int position) {
        return position + "번째";
    }

    @Override
    public String getPossesive(final String name) {
        if ("당신".equals(name) || "You".equalsIgnoreCase(name)) {
            return "당신의";
        }
        return name + "의";
    }

    @Override
    public String getPossessedObject(final String owner, final String object) {
        return getPossesive(owner) + " " + object;
    }

    @Override
    public String getNickName(final String name) {
        String [] splitName = name.split(",");
        if (splitName.length > 1) return splitName[0].trim();
        return name;
    }
}

"I've drafted the LangKorean.java class based on Korean grammar rules. Here are the key points:"

1. Ordinal: It adds "번째" after the number (e.g., 1번째, 2번째).

2. Possessive: It adds the particle "의" to the name (e.g., 제이스의).

3. Spacing: Unlike Japanese or Chinese, Korean requires a space between the possessive form and the object, just like English.

4. Nickname: It splits the name by a comma (,) to handle card titles properly.

As I mentioned, I don't know how to code, so I got this information through an AI. I've reviewed the explanation, and it seems okay for Korean grammar.

[Hanmac]

@kevlahnota @tehdiplomat can someone help me to find the Korean Font as TTF? the Online Converter that converts the OTF makes files that are way too small for my opinion

[viola0081]

I’ve converted the fonts to TTF, and they work without any crashes. I couldn’t see any difference between these three, so I’m uploading all of them for you to choose.

SourceHanSansKR.zip

[Hanmac]

i hadn't time yet to make an MR for this

@viola0081 its probably South-Korean, right? We probably need to differ between South and North, right?

[Jetz72]

its probably South-Korean, right? We probably need to differ between South and North, right?

Is the question whether we'd eventually want to do a separate translation for the dialect of North Korea?

[viola0081]

Yes, it's South Korea

[github-actions]

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.