Skip to content

Adventure: QOL improvements for "Clear All" quests#10244

Merged
Agetian merged 4 commits intoCard-Forge:masterfrom
jumpinjackie:fix/clear-all-quest-qol
Apr 5, 2026
Merged

Adventure: QOL improvements for "Clear All" quests#10244
Agetian merged 4 commits intoCard-Forge:masterfrom
jumpinjackie:fix/clear-all-quest-qol

Conversation

@jumpinjackie
Copy link
Copy Markdown
Contributor

@jumpinjackie jumpinjackie commented Apr 2, 2026

AI Disclosure: All code in this PR up to this point of submission was written by GitHub Copilot, based on the original issue description as the planning prompt with further refinements through additional natural language prompts. I've dabbled in Java (C#, JavaScript, TypeScript are my predominant languages), so I should be able to follow-up on any implementation feedback. I may tap into further assistance from Copilot for addressing any architectural-level concerns.

This PR improves the QoL around "Clear All" quests in Adventure Mode.

Firstly, if you are in a cave/dungeon with an active "Clear All" quest, the remaining enemy count is shown on the bottom right.

Screenshot_20260402_233507

When dealing with hidden enemies, manually walking/scanning every pixel on the map to find these hidden enemies is not my (and many others) idea of fun. Showing the enemy count doesn't really help in this respect, so this PR includes an opt-in setting to draw chevrons pointing to each hidden enemy.

Screenshot_20260403_021953

When this flag is active, chevrons will point to the hidden enemies.

Screenshot_20260402_233449

Chevrons are never drawn for visible enemies in a "Clear All" quest.

Fixes #7845 (and many other closed-via-inactivity duplicates. This one was chosen because it was the one referenced in the Adventure Mode Subproject)

…aining enemies when in a dungeon with an active "clear all" quest.
…Gate this behavior behind a new "Draw chevrons pointing to hidden enemies in a clear all quest" flag in settings.
@Jetz72 Jetz72 requested review from Agetian and Simisays April 2, 2026 13:42
@Jetz72 Jetz72 added Adventure For the Adventure Module QOL Quality of Life labels Apr 2, 2026
@Agetian
Copy link
Copy Markdown
Contributor

Agetian commented Apr 5, 2026

Looks good for merge imo, but needs a conflict resolution in one of the files

@Agetian Agetian self-requested a review April 5, 2026 16:03
@jumpinjackie
Copy link
Copy Markdown
Contributor Author

Merge conflict resolved

@Agetian Agetian merged commit f6289a2 into Card-Forge:master Apr 5, 2026
2 checks passed
@jumpinjackie jumpinjackie deleted the fix/clear-all-quest-qol branch April 5, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adventure For the Adventure Module QOL Quality of Life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Quest Caves/Dungeons that have a "clear all" requirement, count remaining enemies in the HUD

3 participants