Placeholder Faces / CopyFaceFrom#10288
Merged
tehdiplomat merged 3 commits intoCard-Forge:masterfrom Apr 11, 2026
Merged
Conversation
Jetz72
added
Enhancement
Hanmac
reviewed
Apr 5, 2026
Hanmac
reviewed
Apr 5, 2026
Agetian
approved these changes
Apr 7, 2026
Contributor
|
@tool4ever @tehdiplomat can this be merged as requirement for #10233 ? |
tehdiplomat
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the syntax
CopyFaceFrom:<card face name>to card scripts. Doing this will inherit the entire card face defined in a separate card script. A couple playtest split cards are included which use and demonstrate this feature, but it primarily enables Prepare creatures to reference existing spells (#10233).Updates some parts of the code that use
getAllCards(cardName)to usegetAllCardsNoAlt(cardName), now that the distinction is more meaningful. Added a doc comment on each with detailed examples, but in essence, the former will find any card that has the given name on any of its faces, and the latter will only match a full card name.