Working card image downloader#10413
Merged
Agetian merged 2 commits intoCard-Forge:masterfrom Apr 16, 2026
Merged
Conversation
Contributor
Author
|
Notably, the CDN is not used for this bulk downloading. The internal rate limiter seems to be sufficient. If we were to improve this, using the scryfall.io links from the scryfall dataset is necessary. Currently they are not available AFAICT. |
Contributor
|
In general I like the idea, preparing for offline holidays etc. |
Contributor
|
Yeah, looks good to me too :) |
Agetian
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a section below "Download Skins" called "Download Card Images".
The menu from "Download Card Images" allows set selection, but also scryfall-lang filter. The values are updated dynamically. Downloading images does store the images, but does not refresh the stored/cached information currently. To see up-to-date cached image information after download, the game must be restarted.