Restore Android record deserialization fallback in TrackableSerializer#10595
Merged
tool4ever merged 1 commit intoCard-Forge:masterfrom May 4, 2026
Merged
Conversation
<!-- -->Card-Forge#10343 replaced GameEventProxy with TrackableSerializer but did not carry forward the readClassDescriptor() override added in <!-- -->Card-Forge#10304. Android's D8 desugars records to regular classes with computed serialVersionUIDs, while the JVM hardcodes 0L for records — so every GameEvent now fails to deserialize on Android clients in cross-platform network play (visible as "TrackableSerializer: Failed to unwrap event: ... local class incompatible: stream classdesc serialVersionUID = 0, local class serialVersionUID = ..." warnings). Re-applies the same pattern used in CObjectInputStream and the deleted GameEventProxy: when the stream's UID disagrees with the local class UID, fall through to the local descriptor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MostCromulent
force-pushed
the
fix-trackableserializer-record-uid
branch
from
b1a26f3 to
2a36c9c
Compare
tool4ever
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10590
Restores the
readClassDescriptor()fallback that #10304 added for Android's record-vs-JVM serialVersionUID mismatch. The fallback was accidentally dropped when #10343 replacedGameEventProxywithTrackableSerializer—resolveObjectgot carried over, the descriptor override did not.🤖 Generated with Claude Code