Drop redundant global search in Game.findByView else branch#10604
Merged
tool4ever merged 1 commit intoMay 5, 2026
Conversation
When a CardView has no controller or zone, the else branch invoked forEachCardInGame and the subsequent stale-zone-info fallback then invoked it again on the same visitor. Removing the else branch lets the fallback handle that case in a single global walk. Behaviour is otherwise identical: CardIdVisitor.getFound() is idempotent, so the other paths reach the same result. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Hanmac
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Hanmac in #10343 (comment).
When a
CardViewhas no controller or zone, the else branch inGame.findByViewinvokesforEachCardInGame, and the existing stale-zone-info fallback then invokes it again on the same visitor. Removing the else branch lets the fallback handle that case in a single global walk. Behaviour is otherwise identical —CardIdVisitor.getFound()is idempotent, so the stack and controller+zone paths reach the same result.🤖 Generated with Claude Code