SNC: 11 April #13
Merged
SNC: 11 April #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agetian
approved these changes
Apr 12, 2022
kevlahnota
pushed a commit
that referenced
this pull request
Jun 2, 2023
MostCromulent
added a commit
to MostCromulent/forge
that referenced
this pull request
Jan 27, 2026
Bug #12: Collection lookup failures in 3+ player games - Split object creation into two phases in NetworkGuiGame.applyDelta() - Phase 1a: Create all objects and register in tracker - Phase 1b: Apply properties (cross-references now work) - Added createObjectOnly() method for phase separation - Fixed type name logging in NetworkTrackableDeserializer Bug Card-Forge#13: Checksum mismatch due to player ordering - Sort players by ID before computing checksum in DeltaSyncManager - Sort players by ID before computing checksum in NetworkGuiGame - Ensures consistent iteration order between server and client Also fixed: - Log file overwrites by adding batch number to filenames - Updated log analyzer regex patterns for new naming format Test results: 100% success rate, 0 checksum mismatches Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MostCromulent
added a commit
to MostCromulent/forge
that referenced
this pull request
Jan 30, 2026
Merges all code changes from dev branch excluding: - testlogs/ (test artifacts) - .documentation/ (internal docs) - CLAUDE.md, .claude/ (AI assistant config) Key changes included: - Network debug logs now save to user directory (networklogs/) - PreferencesStore pattern for network debug config - Server-side AI option for multiplayer testing - Multiplayer desync bug fixes (#12, Card-Forge#13) - Enhanced test infrastructure and analysis tools Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.