HBG: Specialize face images for local/FTP#1438
Merged
kevlahnota merged 3 commits intoCard-Forge:masterfrom Sep 19, 2022
Merged
Conversation
Contributor
|
so what's not working? the scryfall code for downloading? |
Contributor
Author
Correct – Scryfall download doesn't work |
Contributor
hmm maybe you can use the uri or the id instead of the collector edition from the all parts (main card) specifically for the specialize card, it has the the link and name and just filter them on ImageUtil getdownloadurl (replace the first parts and convert them to jpg links).. |
paulsnoops
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE 9/6/22
Works for local images
Works for images on the FTP
Does not auto-download from Scryfall (I think I will leave that for a different PR/someone else)