Fix for QuestCommander deck editor#5598
Merged
Merged
Conversation
Contributor
|
@Jetz72 the person who added commander quest was very unfamiliar with the codebase and slapped it together without knowing how things should be done |
tehdiplomat
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue where quest commander was functioning as quest mode in some ways, like commander mode in other ways, and like quest commander in no way whatsoever.
In doing this, I deleted this condition from the deck editor's constructor:
Removing something commented with the words "fix saving" leaves me very nervous because I'm not sure exactly what the issue there was. I did run into these lines in
QuestMenu.javathat seem like they could cause a quest commander deck saving issue since they don't includeEditorType.QuestCommander:I added such a line in, and haven't encountered any issues while testing it. Still, if that's all it needed, I'm not sure why the workaround solution was used.
All this to say, if anybody knows any more details about this, please chime in.