Mobile Deck Editor Reorganization and Feature Update#7519
Conversation
# Conflicts: # forge-gui-mobile/src/forge/adventure/scene/AdventureDeckEditor.java
# Conflicts: # forge-gui-mobile/src/forge/itemmanager/views/ImageView.java
# Conflicts: # forge-core/src/main/java/forge/util/ItemPool.java # forge-gui-mobile/src/forge/adventure/scene/AdventureDeckEditor.java
Partial draft support for mobile editor. Auto-sell now a separate tab.
# Conflicts: # forge-core/src/main/java/forge/card/CardDb.java # forge-core/src/main/java/forge/card/ICardDatabase.java # forge-core/src/main/java/forge/deck/CardPool.java # forge-core/src/main/java/forge/item/PaperCard.java # forge-core/src/main/java/forge/util/ItemPool.java # forge-gui-mobile/src/forge/adventure/player/AdventurePlayer.java # forge-gui-mobile/src/forge/adventure/scene/AdventureDeckEditor.java # forge-gui-mobile/src/forge/adventure/stage/ConsoleCommandInterpreter.java # forge-gui-mobile/src/forge/deck/FDeckEditor.java # forge-gui-mobile/src/forge/itemmanager/views/ImageView.java # forge-gui/res/languages/en-US.properties
# Conflicts: # forge-gui/src/main/java/forge/gamemodes/planarconquest/ConquestUtil.java
# Conflicts: # forge-gui/res/languages/de-DE.properties # forge-gui/res/languages/en-US.properties # forge-gui/res/languages/es-ES.properties # forge-gui/res/languages/fr-FR.properties # forge-gui/res/languages/it-IT.properties # forge-gui/res/languages/ja-JP.properties # forge-gui/res/languages/pt-BR.properties # forge-gui/res/languages/zh-CN.properties
|
Think this is just about ready for review. I'm sure I didn't catch everything but I've at least tested each component a few times for outstanding issues. Stuff to do in future PRs or projects:
|
|
Hmmm changing art for the card has a advanced search button if there's a lot of variants (like basic land), and if isn't disabled or hidden (Adventure Mode), then the UI will be stucked after trying to exit from the advanced search screen unless this is also covered though, there's a pr that allows you to advance search like scryfall, I think that's more preferable option I guess in the future. |
Remove backButton override behavior from deck editor.
# Conflicts: # forge-gui-mobile/src/forge/deck/FDeckEditor.java
|
Alright, I think I've patched up the back button functionality enough for it to not break in adventure mode. Still has problems, but it should be more resistant against soft-locking or navigating anywhere weird now. Also took out the home menu bar from the advanced filter screen, and restored the ability to use it to filter the card manager while in adventure mode. Finally, ported over the foil toggle. The new foil effect looks really good by the way, @kevlahnota. |


Ongoing overhaul to the mobile deck editor. Large parts of it have been revised, along with parts of the systems it ties into.
Major goals of this update:
EditorTypeenum used across a bunch of switch statements in the editor, replacing it withDeckEditorConfig, a class that supplies these behavioral differences through overrides of its methods. Vastly reduces hard-coding of game-type specific things into the deck editor itself.Closes #6993; Closes #3652; Closes #8141.