Add version check warning for network play#9698
Merged
tool4ever merged 1 commit intoCard-Forge:masterfrom Feb 8, 2026
Merged
Conversation
Client sends its Forge version in LoginEvent during the connection handshake. Server compares it against the host version and broadcasts a chat warning if they differ, advising players to use the same version to avoid network compatibility issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requested by @tool4ever in #9642 — small standalone PR to give hosts visibility over potential version mismatches before they cause problems.
Details
Adds a
versionfield toLoginEvent, populated withBuildInfo.getVersionString(). The server checks it inLobbyInputHandlerafter the player is assigned a lobby slot. Three cases:Backward compatible —
serialVersionUIDis unchanged, so old clients/servers handle the new field gracefully (defaults tonull).3 files changed, +24 −2 lines.
Test plan
mvn -U -B clean test) — all 13 modules pass🤖 Generated with Claude Code