Skip to content

Add Audio menu with volume sliders to Forge context menu#9742

Merged
tool4ever merged 2 commits intoCard-Forge:masterfrom
MostCromulent:NetworkPlay/audioslider
Feb 14, 2026
Merged

Add Audio menu with volume sliders to Forge context menu#9742
tool4ever merged 2 commits intoCard-Forge:masterfrom
MostCromulent:NetworkPlay/audioslider

Conversation

@MostCromulent
Copy link
Contributor

@MostCromulent MostCromulent commented Feb 13, 2026

Untitled

Summary

Adds an "Audio" submenu to the Forge popup menu (top-left hamburger) with draggable volume sliders for sound effects and music, and fixes the desktop audio backend to actually respect volume settings.

Addresses #9736 — audio can now be quickly adjusted or muted from the Forge context menu without navigating to preferences.

  • New "Audio" menu between "Layout" and "Help" with 0–100 sliders for sound effects and music volume
  • Setting volume to 0 disables audio; raising it above 0 re-enables it
  • Slider positions persist across restarts via existing UI_VOL_SOUNDS/UI_VOL_MUSIC preferences
  • Fixes AudioClip and AltSoundSystem to apply volume via MASTER_GAIN (previously ignored the volume parameter)
  • Fixes AudioMusic.setVolume() which was a //todo no-op — now scales PCM samples via a custom JavaSoundAudioDevice

🤖 Generated with Claude Code

Add an "Audio" submenu to the Forge popup menu with draggable volume
sliders for sound effects and music. Wire up the audio backend to
actually respect volume settings — AudioClip and AltSoundSystem now
apply volume via MASTER_GAIN, and AudioMusic scales PCM samples via
a custom JavaSoundAudioDevice. Sliders sync with the enable/disable
preferences so volume=0 disables audio.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Jetz72 Jetz72 added Desktop Audio Sound and Music labels Feb 13, 2026
@tool4ever tool4ever linked an issue Feb 13, 2026 that may be closed by this pull request
The audio slider changes on this branch make the in-game Sound Effects
toggle redundant.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tool4ever tool4ever merged commit f7d94fe into Card-Forge:master Feb 14, 2026
2 checks passed
@MostCromulent MostCromulent deleted the NetworkPlay/audioslider branch February 15, 2026 04:42
@MorihiroS
Copy link

@MostCromulent @tool4ever Everything is fine, but there is a problem. When you minimize the game and then reopen it, the volume level returns to what it was before, even though the slider is where I set it. If you move it slightly, the volume starts to match the slider.

@MostCromulent MostCromulent restored the NetworkPlay/audioslider branch February 16, 2026 10:34
@MostCromulent MostCromulent deleted the NetworkPlay/audioslider branch February 17, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Audio Sound and Music Desktop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add volume control

4 participants