Merged
Conversation
…reater details and prettier JSON
…r building simple-payment transaction. Fixed metadata deserialisation when it doesn't exist
…regateValue -> Balance, fixed null TranscationWitnessSet deserialisation for view transaction
…better koios response binding
Closed
safestak-keith
commented
Jul 1, 2022
| // Fee Calculation | ||
| var fee = tx.CalculateFee(protocolParams.MinFeeA, protocolParams.MinFeeB); | ||
| txBodyBuilder.SetFee(fee); | ||
| var fee = tx.CalculateAndSetFee(protocolParams.MinFeeA, protocolParams.MinFeeB); |
Collaborator
Author
There was a problem hiding this comment.
@nothingalike FYI removal of a few lines thanks to the latest update to CardanoSharp.Wallet. Also note the removal of TransactionBodyBuilder.Create.SetFee(0) above.
Derive Key and Address for Internal RoleType aka Change
…s to the output text. i set the initial fee to the min b fee like we discussed. I was getting an error for too low fee until adding it
…harp/cscli into feature/new-tx-commands
Member
|
Testing build, sign, and submit worked as intended. Heres my condensed version which just uses more of the options of build command to submit directly/immediately |
nothingalike
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Transaction Commands
Build Simple Payment Transaction
Creates (+ optionally signs & submits) a transaction for a payment of ADA from an address to another address.
Build and Submit Signed Simple Payment
Build Signed Simple Payment Tx with cardano-cli Output File
Sign Transaction
Signs (aka append VKey Witnesses) for a transaction from one or more signing keys.
View Transaction
Views a JSON representation of the transaction including the transaction ID.