Skip to content

Fix confusing variable name#56

Merged
RomanSyunyaev merged 1 commit intomainfrom
js_fix_var_name
Feb 7, 2025
Merged

Fix confusing variable name#56
RomanSyunyaev merged 1 commit intomainfrom
js_fix_var_name

Conversation

@joeyshuttleworth
Copy link
Copy Markdown
Collaborator

Description

Fix the calculation of the index of the first -120mV step.

The variable first_120mV_step_index was originally assigned the index of the preceding +40mV step, causing confusion.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

Copy link
Copy Markdown
Contributor

@RomanSyunyaev RomanSyunyaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joe, have you test it?

I feel like this [i for i, line in enumerate(protocol_desc) if line[2] == 40][0] is going to be a list. X+1 should not work properly, when X is a list (only when X is a numpy array). Am I wrong here?

So it should be something like i+1 for i, ... isntead.

@joeyshuttleworth
Copy link
Copy Markdown
Collaborator Author

Joe, have you test it?

I feel like this [i for i, line in enumerate(protocol_desc) if line[2] == 40][0] is going to be a list. X+1 should not work properly, when X is a list (only when X is a numpy array). Am I wrong here?

So it should be something like i+1 for i, ... isntead.

I'll test locally now. It looks like something's broken with the workflow

@joeyshuttleworth
Copy link
Copy Markdown
Collaborator Author

It seems to work fine locally, and the testing workflow is running now.

Copy link
Copy Markdown
Contributor

@RomanSyunyaev RomanSyunyaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it as well, seems to be working since that's integer not a list. My bad.

@RomanSyunyaev RomanSyunyaev merged commit 8dfc175 into main Feb 7, 2025
@MichaelClerx MichaelClerx deleted the js_fix_var_name branch June 24, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants