Redirect Reconnect Flow To Successor Provider When Configured#604
Open
boris-careev wants to merge 10 commits into
Open
Redirect Reconnect Flow To Successor Provider When Configured#604boris-careev wants to merge 10 commits into
boris-careev wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the external account reconnect experience so that when an external account provider is configured with a successorID, reconnect silently targets the successor provider instead of the legacy provider.
Changes:
- Hide Refresh and show Reconnect for accounts whose provider has a
successorID(with an exception for delete-in-progress). - Update reconnect behavior to call
connectExternalAccount(successorID ?? id). - Add Storybook preview data/stories to exercise successor-provider scenarios.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/presentational/SingleExternalAccount/SingleExternalAccount.tsx | Adjusts Refresh/Reconnect visibility rules, including successor-provider behavior. |
| src/components/presentational/SingleExternalAccount/SingleExternalAccount.stories.tsx | Adds successor-provider Storybook scenarios for the presentational component. |
| src/components/container/ExternalAccountList/ExternalAccountList.tsx | Reconnect now targets successorID ?? id; adds preview state for successor demo data. |
| src/components/container/ExternalAccountList/ExternalAccountList.stories.tsx | Adds a successor-provider story (but currently has issues with args wiring / previewState values). |
| src/components/container/ExternalAccountList/ExternalAccountList.previewdata.tsx | Adds preview data including providers with successorID. |
| package.json | Bumps version to a prerelease identifier for this change set. |
| package-lock.json | Keeps lockfile version in sync with package.json version change. |
Comments suppressed due to low confidence (2)
src/components/container/ExternalAccountList/ExternalAccountList.stories.tsx:70
- The
Livestory is not configuring its own args: it declaresexport const Live = ...but then assigns toDefault.args, overwriting the Default story instead. Update this to setLive.args(and keepDefault.argsintact) so Storybook renders both stories as intended.
export const Live = Template.bind({});
Default.args = {
externalAccountProviderCategories: ["Provider", "Health Plan", "Device Manufacturer"]
};
src/components/presentational/SingleExternalAccount/SingleExternalAccount.tsx:88
- Using
href="javascript:{}"for the Reconnect control is brittle (can be blocked by CSP) and is not ideal for accessibility/semantics. Prefer rendering this as a<button type="button">(or the existingUnstyledButton) so it behaves like an action rather than a navigation link.
<p>
<a href="javascript:{}" onClick={() => props.onReconnectAccount(props.externalAccount)}>
<FontAwesomeSvgIcon icon={faRepeat} /> {language("external-account-reconnect")}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+65
| export const WithSuccessorProvider = Template.bind({}); | ||
| WithSuccessorProvider.args = { | ||
| previewState: "withSuccessor", | ||
| externalAccountProviderCategories: ["Provider"] | ||
| }; |
Comment on lines
+84
to
86
| {(getStatus() === "unauthorized" || (!!props.externalAccount.provider.successorID && getStatus() !== "deleting")) && | ||
| getStatus() !== "fetchingData" && getStatus() !== "deleting" && | ||
| <p> |
Comment on lines
78
to
80
| <p> | ||
| <a href="javascript:{}" onClick={refresh}> | ||
| <FontAwesomeSvgIcon icon={faRepeat} /> {language("external-account-refresh")} |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When a provider has a
successorIDconfigured, the existing Reconnect button now silently targets the successor provider instead of the legacy one - no additional UI or user-facing wording is introduced.Changes:
SingleExternalAccount: Only the Reconnect link is shown for accounts whose provider has asuccessorID, regardless of the account's sync status (except while the account is being deleted or refreshed). Previously it only appeared onunauthorizedaccounts.ExternalAccountList:reconnectAccountnow resolves the provider ID assuccessorID ?? id, so theconnectExternalAccountcall targets the successor when one is configured. The backend is then responsible for detecting the predecessor account and cleaning it up after the successor connection succeeds.Security
These changes only alter which provider ID is passed to the existing
connectExternalAccountAPI call. No new endpoints, no credentials, no data exposure. The successor ID comes from the provider model already returned by the API.Testing
To test, configure a provider with a
successorIDin the backend and verify:externalaccountproviders/{successorID}/connect).successorIDretain existing reconnect behavior unchanged.Documentation
@CareEvolution/api-docs.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:
Consider "Squash and merge" as needed to keep the commit history reasonable on
main.