Skip to content

Add patientIdentifier and setting Parameters To fhirR4ToManifest (Python & TypeScript)#321

Merged
jeremytwfortune merged 3 commits into
mainfrom
boris-patient-identifier-sdk
Nov 14, 2025
Merged

Add patientIdentifier and setting Parameters To fhirR4ToManifest (Python & TypeScript)#321
jeremytwfortune merged 3 commits into
mainfrom
boris-patient-identifier-sdk

Conversation

@boris-careev
Copy link
Copy Markdown
Contributor

Description of Changes

  • Add optional patientIdentifier parameter to ConvertFhirR4ToManifestRequest type in TypeScript
  • Add optional patient_identifier parameter to fhir_r4_to_manifest method in Python
  • Update parameter handling to pass patientIdentifier to the API endpoint

Issue Link

This PR addresses the following issues:

https://github.com/CareEvolution/IO/issues/387

Security

REMINDER: All file contents are public.

  • I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc. Of particular note: No temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • My changes do not introduce any security risks, or any such risks have been properly mitigated.

Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.

Change Control Board (CCB) Approval

CCB approval is required when the change affects organizational processes (like vulnerability management or disaster recovery), or has the potential to impact availability, security, or privacy. See the CR process for more detailed assessment guidelines.

  • This change does NOT require CCB approval.
  • This change DOES require CCB approval. Tag @careevolution/ccb.

Testing/Validation

Describe how we will know if the change is working as intended. Consider both pre-production testing and post-implementation validation, including environment/configuration details, if applicable.

TODO: REPLACE WITH YOUR TESTING/VALIDATION PLAN

Backout Plan

Describe how we will restore the system to its pre-change state if something goes wrong.

Reverse merge-commit

Implementation Notes

Describe any special considerations for implementing the change: scheduling constraints, down-time planning, if a co-pilot is needed, etc.

TODO: REPLACE WITH IMPLEMENTATION NOTES

Documentation Updates

Describe any necessary updates. Consider both internal (wiki, checklists) and external (user guides, developer docs, customer communications) documentation.

  • This change has no documentation impact.
  • This change impacts external documentation (API docs, user guides). Tag @careevolution/mdhd-docs or @careevolution/api-docs.
  • This change impacts internal documentation (procedures, security plans, wiki). Tag the owner.

TODO: REPLACE WITH A DESCRIPTION OF DOCUMENTATION UPDATES, if applicable

Reviewers

  • I have assigned the appropriate reviewer(s).

Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including subject-matter experts and editing/style reviewers.

Add optional patientIdentifier parameter to ConvertFhirR4ToManifestRequest type in TypeScript
Add optional patient_identifier parameter to fhir_r4_to_manifest method in Python
Update parameter handling to pass patientIdentifier to the API endpoint
Comment thread python/orchestrate/_internal/convert.py Outdated
- `content`: A FHIR R4 bundle
- `delimiter`: The delimiter to use in the CSV files. Allowed delimiters are | or ~ or ^ or ; Default delimiter is ,
- `source`: The source of the FHIR R4 bundle to be included in the provenance file
- `patient_identifier`: A patient identifier to add to identifier list of patient resource in the FHIR bundle
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    - `patient_identifier`: The identifier to use as patient.identifier in patient manifest. If this is not provided, the default identifier from the patient resource in bundle is used

Copy link
Copy Markdown
Contributor

@bindu-careev bindu-careev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add support for a setting query parameter in this same PR?

setting: This is a pre-coordinated value to allow an API user to control manifest output in terms of the columns included in a specific manifest file or the order of the columns. If not provided, expect the default manifest output, as documented.

Comment thread python/orchestrate/_internal/convert.py Outdated
@bindu-careev
Copy link
Copy Markdown
Contributor

@boris-careev once you add the clarification to the query param, we can get this merged.
@jeremytwfortune - will need your help on this please.

@boris-careev
Copy link
Copy Markdown
Contributor Author

@boris-careev once you add the clarification to the query param, we can get this merged. @jeremytwfortune - will need your help on this please.

Done, waiting for your approval, @lynnfaraday, so merging is unblocked

@jeremytwfortune jeremytwfortune merged commit 2bc4b6f into main Nov 14, 2025
13 of 19 checks passed
@jeremytwfortune jeremytwfortune deleted the boris-patient-identifier-sdk branch November 14, 2025 00:22
@bindu-careev bindu-careev changed the title Add patientIdentifier Parameter To fhirR4ToManifest (Python & TypeScript) Add patientIdentifier and setting Parameters To fhirR4ToManifest (Python & TypeScript) Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants