Skip to content

Evaluate ci/cd and precommit checks #2382

@danoswaltCL

Description

@danoswaltCL

Now that we're in ECS it's a good time to reevaluate our quality-control checks to make sure they're doing what we want. Some things are definitely not great:

  • Currently ci/cd checks are not running tests / typecheck.

They did for the beanstalk builds, we prob just need to tell it to run the commands we want in Jenkinsfile. They should only run on relevant code changes (i.e. frontend changes don't trigger backend tests, etc).

  • Currently our pre-commit hooks are always running tests on everything, not just the relevant code.

Lint checks are at least limited to relevant code though. VSCode settings for eslint/prettier (at least for me) are not quite consistent with the lint checks, so sometimes the checks will "fix" and commit linting issues uncaught by editor that were introduced by other devs for whatever reason and we end up with commits that have files with lint-only changes. Not a huge deal but in bigger PRs it's unhelpful for reviewing purposes to have to ignore those diffs.

Requirements:

On precommit:

  • Linting and Typechecking only the relevant files
  • No need for running unit tests... you should be doing this anyway!

CICD

  • Do linting and typechecking still
  • Run all the unit tests

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions