Logger not found in middleware crashes backend App

[bcb37]

This PR: #2765 contains a description of the issue.

[zackcl]

Here are the last few logs from when the crash happened, for reference:

upgrade-app_1  | [1] {"endpoint":"/v4/users/23","level":"info","message":{"content_length":154,"http_version":"1.1","method":"GET","referrer":"https://52.21.71.129/","remote_address":"::ffff:10.0.2.204","status_code":"404","time":"2025-11-26T20:54:15.259Z","total-time":"0.767","url":"/api/v4/users/23","user_agent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.124 Safari/537.36"},"request_id":"c4cd50d2-cbd2-443e-b2a4-9ac7b3a7a448","request_method_type":"GET"}
upgrade-app_1  | [1] {"endpoint":"/v4/users/22","level":"info","message":{"content_length":154,"http_version":"1.1","method":"GET","referrer":"https://52.21.71.129/","remote_address":"::ffff:10.0.2.204","status_code":"404","time":"2025-11-26T20:54:15.263Z","total-time":"0.378","url":"/api/v4/users/22","user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0"},"request_id":"e4b0f102-a713-43a7-b843-c946d7d4ec30","request_method_type":"GET"}
upgrade-app_1  | [1] {"endpoint":"/","level":"info","message":{"content_length":"96","http_version":"1.1","method":"GET","remote_address":"::ffff:10.0.3.15","status_code":"200","time":"2025-11-26T20:54:15.332Z","total-time":"0.439","url":"/api","user_agent":"ELB-HealthChecker/2.0"},"request_id":"f2ee117c-cf4e-4062-9090-cee274f219a8","request_method_type":"GET"}
upgrade-app_1  | [1] {"endpoint":"/v4/users/25","level":"info","message":{"content_length":154,"http_version":"1.1","method":"GET","referrer":"https://52.21.71.129/","remote_address":"::ffff:10.0.2.204","status_code":"404","time":"2025-11-26T20:54:16.258Z","total-time":"0.970","url":"/api/v4/users/25","user_agent":"Mozilla/5.0 (X11; CrOS x86_64 14816.131.5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36"},"request_id":"c3d1ccfc-e01d-41ec-955e-148fc7a1eb44","request_method_type":"GET"}
upgrade-app_1  | [1] {"endpoint":"/v4/users/24","level":"info","message":{"content_length":154,"http_version":"1.1","method":"GET","referrer":"https://52.21.71.129/","remote_address":"::ffff:10.0.2.204","status_code":"404","time":"2025-11-26T20:54:16.259Z","total-time":"1.120","url":"/api/v4/users/24","user_agent":"Mozilla/5.0 (Windows NT 10.0; rv:109.0) Gecko/20100101 Firefox/117.0"},"request_id":"7151c3f1-0870-4af5-bcac-ad5e294650fb","request_method_type":"GET"}
upgrade-app_1  | [1] {"date":"Wed Nov 26 2025 20:54:18 GMT+0000 (Coordinated Universal Time)","error":{},"exception":true,"level":"error","message":"uncaughtException: Cannot read properties of undefined (reading 'error')\nTypeError: Cannot read properties of undefined (reading 'error')\n    at ErrorHandlerMiddleware.<anonymous> (/usr/src/app/backend/packages/Upgrade/src/api/middlewares/ErrorHandlerMiddleware.ts:126:16)\n    at Generator.next (<anonymous>)\n    at /usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js:170:75\n    at new Promise (<anonymous>)\n    at Object.__awaiter (/usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js:166:16)\n    at ErrorHandlerMiddleware.error (/usr/src/app/backend/packages/Upgrade/dist/src/api/middlewares/ErrorHandlerMiddleware.js:16:24)\n    at ErrorHandlerMiddleware (/usr/src/app/backend/packages/Upgrade/node_modules/src/driver/express/ExpressDriver.ts:63:66)\n    at Layer.handle_error (/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/layer.js:71:5)\n    at trim_prefix (/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js:326:13)\n    at /usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js:286:9","os":{"loadavg":[0,0,0],"uptime":1824618.94},"process":{"argv":["/usr/src/app/backend/packages/Upgrade/node_modules/.bin/ts-node","/usr/src/app/backend/packages/Upgrade/dist/src/app.js"],"cwd":"/usr/src/app/backend/packages/Upgrade","execPath":"/usr/local/bin/node","gid":1000,"memoryUsage":{"arrayBuffers":4975771,"external":9081859,"heapTotal":93208576,"heapUsed":82923864,"rss":199733248},"pid":307,"uid":1000,"version":"v22.14.0"},"stack":"TypeError: Cannot read properties of undefined (reading 'error')\n    at ErrorHandlerMiddleware.<anonymous> (/usr/src/app/backend/packages/Upgrade/src/api/middlewares/ErrorHandlerMiddleware.ts:126:16)\n    at Generator.next (<anonymous>)\n    at /usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js:170:75\n    at new Promise (<anonymous>)\n    at Object.__awaiter (/usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js:166:16)\n    at ErrorHandlerMiddleware.error (/usr/src/app/backend/packages/Upgrade/dist/src/api/middlewares/ErrorHandlerMiddleware.js:16:24)\n    at ErrorHandlerMiddleware (/usr/src/app/backend/packages/Upgrade/node_modules/src/driver/express/ExpressDriver.ts:63:66)\n    at Layer.handle_error (/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/layer.js:71:5)\n    at trim_prefix (/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js:326:13)\n    at /usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js:286:9","trace":[{"column":16,"file":"/usr/src/app/backend/packages/Upgrade/src/api/middlewares/ErrorHandlerMiddleware.ts","function":null,"line":126,"method":null,"native":false},{"column":null,"file":null,"function":"Generator.next","line":null,"method":"next","native":false},{"column":75,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js","function":null,"line":170,"method":null,"native":false},{"column":null,"file":null,"function":"new Promise","line":null,"method":null,"native":false},{"column":16,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/tslib/tslib.js","function":"Object.__awaiter","line":166,"method":"__awaiter","native":false},{"column":24,"file":"/usr/src/app/backend/packages/Upgrade/dist/src/api/middlewares/ErrorHandlerMiddleware.js","function":"ErrorHandlerMiddleware.error","line":16,"method":"error","native":false},{"column":66,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/src/driver/express/ExpressDriver.ts","function":"ErrorHandlerMiddleware","line":63,"method":null,"native":false},{"column":5,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/layer.js","function":"Layer.handle_error","line":71,"method":"handle_error","native":false},{"column":13,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js","function":"trim_prefix","line":326,"method":null,"native":false},{"column":9,"file":"/usr/src/app/backend/packages/Upgrade/node_modules/express/lib/router/index.js","function":null,"line":286,"method":null,"native":false}]}
upgrade-app_1  | [1] The script called "serve.production" which runs "cross-env NODE_ENV=production TS_NODE_PROJECT=tsconfig.build.json ts-node -r tsconfig-paths/register dist/src/app.js" failed with exit code 1 https://github.com/sezna/nps/blob/master/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
upgrade-app_1  | [1] npm --prefix ./backend run production:upgrade exited with code 1

I don't think we can determine which exact request triggered the issue, because the error occurred inside the error handler before any request metadata could be logged.

[danoswaltCL]

QA: Dan
Passed!

This curl call from an unauthorized origin would have crashed the app and caused the tasks to restart previously.

curl -X POST https://apps.qa-cli.net/upgrade-service/api \
  -H "Origin: https://unauthorized-domain.com" \
  -H "Content-Type: application/json" \
  -d '{"test": "data"}' \
  -v

This is a random error we would see from time to time in new relic that i never could figure out, it was this and now it logs out clearly.