Skip to content

Fix/issue 134#142

Merged
VivekFitkariwala merged 9 commits intomainfrom
fix/issue-134
Oct 1, 2021
Merged

Fix/issue 134#142
VivekFitkariwala merged 9 commits intomainfrom
fix/issue-134

Conversation

@VivekFitkariwala
Copy link
Copy Markdown
Contributor

  • Added swc transpiler
  • Removed type checking from typescript transpilation and added separate command for transpilation
  • Added husky for pre commit hook for lint and type check during development
  • Added type checking during build

@VivekFitkariwala VivekFitkariwala linked an issue Sep 21, 2021 that may be closed by this pull request
@VivekFitkariwala
Copy link
Copy Markdown
Contributor Author

Husky is added at the root level of the project. So for husky to work properly you need to npm install at the root level.

Comment thread frontend/package-lock.json Outdated
@@ -1,8 +1,16112 @@
{
"name": "ab-testing",
"version": "1.0.52",
"lockfileVersion": 1,
"lockfileVersion": 2,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VivekFitkariwala Do we really need this change as we don't have any changes in the package.json file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to different npm version we are using. I think if we are npm > ^7.0.0 it uses "lockfileVersion": 2. I have reverted the change for now but I think we can force user to use minimum version of npm to avoid this conflict in future

@VivekFitkariwala VivekFitkariwala merged commit 01e5df1 into main Oct 1, 2021
@jerith666
Copy link
Copy Markdown
Contributor

I just got:

$ git commit

> ab-testing@1.0.69 test
> ng test

sh: line 1: ng: command not found
husky - pre-commit hook exited with code 127 (error)

I don't like husky sideloading itself into my local git config without any warning just because I ran npm install. Especially since I use a multi-remote local repo so now husky is going to try to run on a bunch of other repos where it's not wanted. 👎

@jreddig jreddig deleted the fix/issue-134 branch April 20, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove type checking in ts-node to improve dev experience

4 participants