remove pagination from export queries #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppratikcr7
reviewed
Jun 20, 2024
| } else { | ||
| csvExportData = await this.analyticsRepository.getCSVDataForSimpleExport(experimentId, skip, take); | ||
| } | ||
| const userIds = csvExportData.map(({ userId }) => userId); |
Contributor
There was a problem hiding this comment.
why is this part of code removed? We will still execute further code if no data.
Collaborator
Author
There was a problem hiding this comment.
This part was removed because 'break' doesn't make sense outside of a loop.
If the experimentId parameter is undefined then we probably should return immediately.
If there's an experiment with no enrolled students we'll return then
ppratikcr7
reviewed
Jun 20, 2024
| .execute(); | ||
| .where('"individualEnrollment"."experimentId" = :experimentId', { experimentId }); | ||
|
|
||
| console.log(query.getSql()); |
Contributor
There was a problem hiding this comment.
can we remove this console log and the separate constant query created to log it.
ppratikcr7
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.