-
Notifications
You must be signed in to change notification settings - Fork 15
Prevent App Freezing in Metrics Component with Large Datasets #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcb37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good Just one question.
Also, search by 'All' or 'Context' throws an error on lines 168 and 174 of metrics.component.ts in cases where there's no context. It could be fixed by coalescing like : !!data.context?.filter(...
...rojects/upgrade/src/app/features/dashboard/profile/components/metrics/metrics.component.html
Outdated
Show resolved
Hide resolved
|
@bcb37 I resolved all your comments. Please feel free to approve this PR. |
bcb37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarification.
|
@bcb37 I have applied the suggested change. Please feel free to approve the PR. |
.../projects/upgrade/src/app/features/dashboard/profile/components/metrics/metrics.component.ts
Outdated
Show resolved
Hide resolved
.../projects/upgrade/src/app/features/dashboard/profile/components/metrics/metrics.component.ts
Show resolved
Hide resolved
.../projects/upgrade/src/app/features/dashboard/profile/components/metrics/metrics.component.ts
Show resolved
Hide resolved
|
looks good to me too, just one request to avoid the awkward conversion from promise to an observable. Please try that out, I tested it quickly and it worked on the smaller metric dataset that I have loaded in, or seemed to. |
|
@danoswaltCL Thanks for you suggestions. I have resolved all your comments and updated the |
|
I will review this one more time. |
|
I'd approve, looks to be back to draft though, did you find an issue? |
|
I realized I didn’t need to update the |
0bfee49 to
e6e82fb
Compare
…eteNode function to work
|
@danoswaltCL Sorry for the delay, the PR is ready now. After resolving your comments (e6e82fb), I made one more commit (0db0de5) to make the node deletion work properly. Please feel free to approve this PR. |
This PR (Resolves #1796) addresses a critical issue where the Metrics component causes the app to freeze when rendering large metrics datasets up front.
The PR implements a lazy loading mechanism for the metrics tree structure, which:
tree-invisibleclass usage (reference)