Fix undefined segment errors in Feature Flag Inclusion and Exclusion selectors #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcl
requested review from
RidhamShah,
VivekFitkariwala,
Yagnik56,
bcb37,
danoswaltCL and
ppratikcr7
bcb37
approved these changes
Sep 9, 2024
Collaborator
bcb37
left a comment
bcb37
left a comment
There was a problem hiding this comment.
This works, but I can't reproduce the error on dev now.
VivekFitkariwala
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1910
This PR fixes the
TypeError: Cannot read properties of undefined (reading 'createdAt')error that occurs when navigating to some Feature Flag details pages. This error is caused by attempting to access thecreatedAtproperty fromsegmentwhensegmentis not available from the store (This issue started happening after merging #1907 which includedfeatureFlagSegmentInclusionin theflags/paginatedresponse). The fix involves adding a filter step:.filter((inclusion) => inclusion.segment)to ensure segment exists before accessing its properties. This PR also simplifies the existing selector code.