Skip to content

Implement Segment Import List Modal #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zackcl merged 3 commits into from
Apr 11, 2025
Merged

Implement Segment Import List Modal #2368

zackcl merged 3 commits into from
Apr 11, 2025

Conversation

@zackcl
Copy link
Collaborator

@zackcl zackcl commented Apr 11, 2025

Resolves #2335

@zackcl zackcl requested review from bcb37 and danoswaltCL April 11, 2025 13:08
@zackcl zackcl self-assigned this Apr 11, 2025
@zackcl zackcl changed the title [WIP] Implement Segment Import List Modal Implement Segment Import List Modal Apr 11, 2025
@zackcl zackcl marked this pull request as ready for review April 11, 2025 13:24
@zackcl
Copy link
Collaborator Author

zackcl commented Apr 11, 2025

Ready for review, but tests needed.

bcb37
bcb37 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@bcb37 bcb37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Importing was being blocked because validation was flagging the list name as a duplicate, which is ok in the case of lists. I fixed that in this pr

@zackcl zackcl merged commit 41c0f4b into dev Apr 11, 2025
8 checks passed
@zackcl zackcl deleted the feature/2335-segment-import-list2 branch April 11, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcb37 bcb37 bcb37 approved these changes

@danoswaltCL danoswaltCL Awaiting requested review from danoswaltCL

Assignees

@zackcl zackcl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segment Import List Modal

3 participants

@zackcl @bcb37