Skip to content

use custom data source for transaction #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcb37 merged 2 commits into from
Oct 1, 2025
Merged

use custom data source for transaction #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e8395
use custom data source for transaction
bcb37 Sep 30, 2025
b97b883
fix test
bcb37 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend/packages/Upgrade/src/api/services/QueryService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Service } from 'typedi';
import { InjectDataSource, InjectRepository } from '../../typeorm-typedi-extensions';
import { Container } from './../../typeorm-typedi-extensions/Container';
import { QueryRepository } from '../repositories/QueryRepository';
import { Query } from '../models/Query';
import { LogRepository } from '../repositories/LogRepository';
Expand Down Expand Up @@ -78,7 +79,9 @@ export class QueryService {
return [];
}

const transactionPromise = await this.dataSource.transaction(async (transactionalEntityManager) => {
const customDataSource = Container.getDataSource('export');

const transactionPromise = await customDataSource.transaction(async (transactionalEntityManager) => {
const analyzePromise = promiseResult.map((query) => {
experiments.push(query.experiment);
if (query.experiment?.type === EXPERIMENT_TYPE.FACTORIAL) {
Expand Down
2 changes: 2 additions & 0 deletions backend/packages/Upgrade/test/unit/services/QueryService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { ErrorRepository } from '../../../src/api/repositories/ErrorRepository';
import { ArchivedStatsRepository } from '../../../src/api/repositories/ArchivedStatsRepository';
import { ArchivedStats } from '../../../src/api/models/ArchivedStats';
import { configureLogger } from '../../utils/logger';
import { Container } from '../../../src/typeorm-typedi-extensions';

const logger = new UpgradeLogger();

Expand Down Expand Up @@ -65,6 +66,7 @@ describe('Query Service Testing', () => {
entities: [Query, Experiment, ArchivedStats, ErrorRepository],
synchronize: true,
});
Container.setDataSource('export', dataSource);

dataSource.transaction = jest.fn().mockImplementation((passedFunction) => {
return passedFunction(dataSource.manager);
Expand Down