condition edit/add/delete modal#2705
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality for adding, editing, and deleting experiment conditions through a modal dialog interface. The changes enable users to manage conditions via a dedicated modal component with autocomplete support and proper validation.
Key Changes
- Added new
UpsertConditionModalComponentfor creating and editing conditions with autocomplete functionality - Implemented condition CRUD operations through a new
ConditionHelperService - Added Redux actions, reducers, and effects to handle condition updates
- Connected the UI components to trigger the new modal dialogs
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| en.json | Added translation key for condition hint text |
| common-dialog.service.ts | Added modal service methods for add/edit/delete condition dialogs |
| experiment-conditions-section-card.component.ts | Connected UI actions to modal service methods |
| experiment-conditions-section-card.component.html | Updated template to pass context parameter |
| upsert-condition-modal.component.ts | New modal component with form validation and autocomplete |
| upsert-condition-modal.component.html | Modal template with condition and description fields |
| experiments.reducer.ts | Added reducer handlers for condition update actions |
| experiments.model.ts | Added new interfaces for condition operations |
| experiments.effects.ts | Added effect to handle condition update requests |
| experiments.actions.ts | Added Redux actions for condition updates |
| experiments.service.ts | Added service method to dispatch condition updates |
| experiments.data.service.ts | Added data service method for API calls |
| condition-helper.service.ts | New service implementing condition CRUD logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
danoswaltCL
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.