fix for users not excluded reached prior to experiment state changed to enrolling#573
Merged
fix for users not excluded reached prior to experiment state changed to enrolling#573
Conversation
ppratikcr7
requested review from
VivekFitkariwala,
danoswaltCL,
jreddig and
zackcl
auto-merge was automatically disabled
October 20, 2022 06:54
Pull request was converted to draft
Collaborator
|
As I tested using the testing app (https://upgrade-tester.glitch.me/), everything seems to work as expected. So I think it's good to merge this. |
jreddig
approved these changes
Oct 24, 2022
Contributor
jreddig
left a comment
jreddig
left a comment
There was a problem hiding this comment.
Looks good! Thanks for thoroughly testing, Zack!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.