Skip to content

added themed alias table shading#642

Merged
mfugate1 merged 3 commits intodevfrom
feature/alias-table-shading
Dec 5, 2022
Merged

added themed alias table shading#642
mfugate1 merged 3 commits intodevfrom
feature/alias-table-shading

Conversation

@danoswaltCL
Copy link
Copy Markdown
Collaborator

@danoswaltCL danoswaltCL commented Dec 2, 2022

  • Adds shading to visually highlight site + target groupings on alias table on overview page and stepper page.
  • Uses $theme to make sure this works for both light and dark themes.
  • Set up to be reusable for other tables if we want shading used elsewhere.
  • Refactors duplicate implementations of a alias-table-creation method into one common service method

Screen Shot 2022-12-02 at 5 17 28 PM

Screen Shot 2022-12-02 at 5 17 13 PM

Screen Shot 2022-12-02 at 5 16 57 PM

Screen Shot 2022-12-02 at 5 16 27 PM

Copy link
Copy Markdown
Contributor

@jreddig jreddig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its beautiful. and its in the stepper and experiment detail!

@mfugate1 mfugate1 merged commit bd45407 into dev Dec 5, 2022
@mfugate1 mfugate1 deleted the feature/alias-table-shading branch December 5, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants