Conversation
danoswaltCL
requested review from
Yagnik56 and
ppratikcr7
and removed request for
Yagnik56
danoswaltCL
requested review from
RidhamShah,
VivekFitkariwala,
Yagnik56,
jreddig and
zackcl
ppratikcr7
approved these changes
Dec 8, 2022
mfugate1
deleted the
feature/refactor-utilize-experiment-stepper-service
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to begin reorganizing frontend code that is specific to Experiment Design Stepper Modal all in one place. This initial change should contain no logic changes, just reorganizing and some name changes.
The "Experiment Design Stepper" lacks its own feature store / core services, it really needs to be its own entity. Currently we are overloading the "Experiments" feature with stuff that really should belong in a different spot that is easier to work with and reason about on its own.
This will allow some refactoring to reduce the large amount of redundant code found within the experiment stepper, and a more focused set of files to locate the growing amount of future work that is Experiment Design Stepper focused.