Assembly improvement#39
Merged
JonathanMCarter merged 9 commits intoMay 19, 2026
Merged
Conversation
…ssembly modifications
JonathanMCarter
added
enhancement
Member
Like #38 I want to give this a full test and check things over. May make a few adjustments myself too. But looks like some good improvements! |
| /// It is intended to use this cache to avoid the use | ||
| /// of <see cref="Assembly.GetTypes"/> in each call. | ||
| /// </summary> | ||
| private static readonly Dictionary<Type, List<Type>> TypeCache = new(); |
Member
There was a problem hiding this comment.
Doesn't compile in the base development version of 2020.3.0
Suggested change
| private static readonly Dictionary<Type, List<Type>> TypeCache = new(); | |
| private static readonly Dictionary<Type, List<Type>> TypeCache = new Dictionary<Type, List<Type>>(); |
| /// </summary> | ||
| private static readonly Dictionary<Type, List<Type>> TypeCache = new(); | ||
|
|
||
| private static Assembly[] _cachedAssemblies; |
Member
There was a problem hiding this comment.
Does not match naming conventions. See: https://carter.games/unity-c-style-guide/#7-fields
Suggested change
| private static Assembly[] _cachedAssemblies; | |
| private static Assembly[] cachedAssemblies; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves assembly scan and code by...
It should also slighty improve
SaveGame()andLoadGame().Those changes are quite critical so let me know if you have a question or if you noticed a bug. I tested it on my end and there's nothing alarming so far.