Conversation
This avoids force unwrapping of error in `usage` closure. Some options may return `.Success` case for `CommandMode.Usage` (e.g. `NoOptions`).
Member
|
Good catch! Can we add a test for this? |
ikesyo
force-pushed
the
fix-help-command-crash
branch
from
c78c336 to
8ebcf1a
Compare
Member
Author
|
Thanks, added a test. 😃 |
argon
added a commit
to mas-cli/mas
that referenced
this pull request
Feb 21, 2016
Resolved by: Carthage/Commandant#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids force unwrapping of error in
usageclosure. Some options may return.Successcase forCommandMode.Usage(e.g.NoOptions).Sould fix realm/SwiftLint#312 (comment).