Skip to content

add support for Swift Package Manager#50

Merged
mdiep merged 7 commits intoCarthage:masterfrom
jpsim:spm
Jan 30, 2016
Merged

add support for Swift Package Manager#50
mdiep merged 7 commits intoCarthage:masterfrom
jpsim:spm

Conversation

@jpsim
Copy link
Copy Markdown
Contributor

@jpsim jpsim commented Jan 18, 2016

Pointing to jpsim/Result for now because there's no tag of antitypical/Result containing Package.swift.

Due to swiftlang/swift-package-manager#16, I had to rename CommandantTests to Tests.

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jan 22, 2016

Pointing to jpsim/Result for now because there's no tag of antitypical/Result containing Package.swift.

Could you open a pull request on antitypical/Result to add Package.swift? I'd prefer to have support there before we add support here.

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Jan 22, 2016

antitypical/Result already has a Package.swift but doesn't have a tag with it, which SPM needs. We could point this there, but it wouldn't work until a new release is made.

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jan 29, 2016

I just created a new release for antitypical/Result that includes the Package.swift. If you update this PR, we can merge it. It'd also be nice if we could test the linux build on CI, but I'm not sure what the state of that is.

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Jan 30, 2016

This is pointing to antitypical/Result now. Although Commandant Linux support is blocked on antitypical/Result#135, so I haven't included anything Linux-specific in this PR.

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Jan 30, 2016

I'll be tracking the Linux-specific Commandant changes here: jpsim/Commandant@spm...linux

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jan 30, 2016

Looks great! Thanks! ✨

mdiep added a commit that referenced this pull request Jan 30, 2016
add support for Swift Package Manager
@mdiep mdiep merged commit c383081 into Carthage:master Jan 30, 2016
@jpsim jpsim deleted the spm branch January 30, 2016 20:09
@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Feb 1, 2016

It'd be great to cut a new release of Commandant with this change, so we can stop pointing other SPM projects to unofficial forks 😄 .

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Feb 1, 2016

I'll try to do that tonight or in the morning. 👍

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Feb 2, 2016

Thanks ✨

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Feb 2, 2016

I just released 0.8.3. ✨

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Feb 2, 2016

Fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants