Skip to content

Implement subcommand mechanism#51

Merged
mdiep merged 3 commits intomasterfrom
subcommand
Jan 29, 2016
Merged

Implement subcommand mechanism#51
mdiep merged 3 commits intomasterfrom
subcommand

Conversation

@ikesyo
Copy link
Copy Markdown
Member

@ikesyo ikesyo commented Jan 21, 2016

See Carthage/Carthage#1017 for the context.

Cargo in particular has a plugin architecture, which led to the formation of a bunch of useful sub-commands.

I think carthage would greatly benefit from the addition of either support for similar plugins or the addition of similar sub-commands by default.

Comment thread Commandant/Command.swift Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want there to be a better way to do this… but I guess there's probably not? /cc @Carthage/carthage

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this to use which -s and check the exit status.

@ikesyo
Copy link
Copy Markdown
Member Author

ikesyo commented Jan 25, 2016

Updated. ✨ How do you feel now?

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jan 29, 2016

This looks and works great. 👍 Thanks!

mdiep added a commit that referenced this pull request Jan 29, 2016
Implement subcommand mechanism
@mdiep mdiep merged commit 397c439 into master Jan 29, 2016
@mdiep mdiep deleted the subcommand branch January 29, 2016 21:02
@ikesyo
Copy link
Copy Markdown
Member Author

ikesyo commented Jan 30, 2016

Thanks too! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants