Skip to content

Expose a public initializer to NoOptions so that tests can be written for commands that take NoOptions#55

Merged
mdiep merged 1 commit intoCarthage:masterfrom
younata:master
Feb 11, 2016
Merged

Expose a public initializer to NoOptions so that tests can be written for commands that take NoOptions#55
mdiep merged 1 commit intoCarthage:masterfrom
younata:master

Conversation

@younata
Copy link
Copy Markdown
Contributor

@younata younata commented Feb 11, 2016

Why was this not exposed earlier?

… commands that take NoOptions

Why was this not exposed earlier?
@ikesyo
Copy link
Copy Markdown
Member

ikesyo commented Feb 11, 2016

Why not just call NoOptions<Error>.evaluate(.Usage)?

@younata
Copy link
Copy Markdown
Contributor Author

younata commented Feb 11, 2016

Because NoOptions<Error>() is infinitely more readable.

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Feb 11, 2016

This seems fine. 👍

Why was this not exposed earlier?

I think it just wasn't obvious that it would be useful.

mdiep added a commit that referenced this pull request Feb 11, 2016
Expose a public initializer to NoOptions so that tests can be written for commands that take NoOptions
@mdiep mdiep merged commit f216157 into Carthage:master Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants