Conversation
Member
|
I will take a look in a couple of days. |
Member
I tried an implementation: 715684d. How do you feel about it? |
Member
|
Other than that change, LGTM 👍 |
Conflicts: Tests/OptionSpec.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Carthage/Carthage#1143, it would be nice to use an
Option<String?>for a command-line option. Since the default value isn't really known, it would be preferable to default tonil. This PR makes that possible, but it introduces a breaking change.Optionrequire adefaultValue. Previously, anildefault meant that the parameter was required. Carthage doesn't use this, and I think that behavior is a little silly given that it's called option. If this behavior is required somewhere, I'd rather see another type added.<|that works with anOption<T?>whereT: ArgumentType.The implementation isn't as nice as I'd like. I ran into Swift limitations, segfaults, and, I think, some type inference errors. But ultimately I arrived at something that at least works.