Skip to content

Support Swift 2.3#68

Merged
mdiep merged 5 commits intomasterfrom
swift2.3
Jun 30, 2016
Merged

Support Swift 2.3#68
mdiep merged 5 commits intomasterfrom
swift2.3

Conversation

@ikesyo
Copy link
Copy Markdown
Member

@ikesyo ikesyo commented Jun 28, 2016

No description provided.

ikesyo added 3 commits June 28, 2016 01:37
@ikesyo
Support Swift 2.3
2f3606c
@ikesyo
Disable SwiftPM tests on Travis for Swift 2.3 support (temporarily)
d4f0166 
Those should be recovered on the future commits or the branch that supports Swift 3.0.
@ikesyo
Avoid the use of xctool
2e71847
mdiep
mdiep reviewed Jun 29, 2016
View reviewed changes
Comment thread .travis.yml
dist: trusty
language: generic
install:
- eval "$(curl -sL https://gist.githubusercontent.com/kylef/5c0475ff02b7c7671d2a/raw/02090c7ede5a637b76e6df1710e83cd0bbe7dcdf/swiftenv-install.sh)"
Copy link
Copy Markdown
Member

@mdiep mdiep Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this job need to be removed?

Copy link
Copy Markdown
Member Author

@ikesyo ikesyo Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to update to a recent snapshot as of https://github.com/jpsim/Commandant/tree/jp-05-31-snapshot, but that requires breaking changes and I gave it up. So this should be my fault at that time.

Copy link
Copy Markdown
Member Author

@ikesyo ikesyo Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will restore this.

@ikesyo
Copy link
Copy Markdown
Member Author

ikesyo commented Jun 29, 2016 •
edited
Loading

Oh, I remembered that Result 2.1.0 breaks the builds for DEVELOPMENT-SNAPSHOT-2016-03-24-a.

Swift 3 support has been updated to the 2016-05-31 snapshot

But updating to DEVELOPMENT-SNAPSHOT-2016-05-31-a requires a large number of #if swift(>=3) and I'm not a fun of it (or introducing breaking changes for Swift 3). That is the reason I dropped the SwiftPM tests for now.

@ikesyo
Copy link
Copy Markdown
Member Author

ikesyo commented Jun 29, 2016 •
edited
Loading

Should we support Swift 2.3 and Swift 3 (DEVELOPMENT-SNAPSHOT-2016-05-31-a) simultaneously as Result does on its master? But that will be changed in antitypical/Result#167 and it will be more difficult since we depends on Quick and Nimble. 😞

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jun 29, 2016

I think Commandant can stick to supporting just 1 version of Swift.

@ikesyo
Copy link
Copy Markdown
Member Author

ikesyo commented Jun 30, 2016

Updating Package.swift to use Result 2.0.0 fixed the issue. Unfortunately Travis is in trouble 😞 https://www.traviscistatus.com/incidents/rqb906yypnk0.

@mdiep
Copy link
Copy Markdown
Member

mdiep commented Jun 30, 2016

✨

Just waiting on Travis now. 👍

@mdiep mdiep merged commit 7dc939c into master Jun 30, 2016
@mdiep mdiep deleted the swift2.3 branch June 30, 2016 12:25
@ikesyo ikesyo mentioned this pull request Jul 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ikesyo @mdiep