Skip to content

Loosen determination if a branch is protected + up default sleep#35

Merged
CasperWA merged 2 commits intomasterfrom
fix_34_recognize-gh-actions-checks
Mar 1, 2021
Merged

Loosen determination if a branch is protected + up default sleep#35
CasperWA merged 2 commits intomasterfrom
fix_34_recognize-gh-actions-checks

Conversation

@CasperWA
Copy link
Copy Markdown
Owner

@CasperWA CasperWA commented Mar 1, 2021

Fixes #34

If a 404 response is returned for a /branches/{branch}/protection then
the branch is not protected (as normal), but otherwise it is considered
to be protected (do not expect a special key to be present in the
response in order to determine whether the branch is protected or not).
@CasperWA CasperWA force-pushed the fix_34_recognize-gh-actions-checks branch from 21276fa to d9ad1bf Compare March 1, 2021 16:48
@CasperWA
Copy link
Copy Markdown
Owner Author

CasperWA commented Mar 1, 2021

It seems the branch query parameter is not working properly for the repos/{owner}/{repo}/actions/workflows/{workflow_id}/runs endpoint in the GitHub REST API.

For the get_workflow_runs() query parameter, go through the returned
data and find the temporary branch instead of using the `branch` query
parameter.
@CasperWA CasperWA force-pushed the fix_34_recognize-gh-actions-checks branch from f81d10c to 943d917 Compare March 1, 2021 17:25
@CasperWA CasperWA merged commit 943d917 into master Mar 1, 2021
@CasperWA CasperWA deleted the fix_34_recognize-gh-actions-checks branch March 1, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions checks not recognized as such

1 participant