Feature/default label not working in version 1.0.7 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al; .placeholder) - Moved styling for label-above to appropriate class
…_label_not_working_in_version_1.0.7
- Upgraded castlecss-core to 2.4.0 - Updated the contributors
dariusrosendahl
approved these changes
Jul 5, 2017
Member
dariusrosendahl
left a comment
dariusrosendahl
left a comment
There was a problem hiding this comment.
Had a discussion with the team and we're deciding to implement the change and make it a new major version because the class 'placeholder' will be breaking. Unfortunate, but necessary. There can be more then 1 label[for] within a form-field.
dariusrosendahl
deleted the
feature/#6_Default_label_not_working_in_version_1.0.7
branch
dariusrosendahl
changed the title
dariusrosendahl
restored the
feature/#6_Default_label_not_working_in_version_1.0.7
branch
dariusrosendahl
deleted the
feature/#6_Default_label_not_working_in_version_1.0.7
branch
Paulus90
pushed a commit
that referenced
this pull request
Mar 19, 2018
…ylerules in place only apply to 'placeholder' labels in input fields (not radio/checkbox labels). It broke radiobuttons/checkboxes when their labels contained a [for] attribute - Bear in mind: this fix should be temporary due to an upcoming fix in forms version 2.0 (issue #14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes
When this is approved, the examples need to be updated with this new class