Skip to content

Conversation

@gbeumer
Copy link

@gbeumer gbeumer commented Jan 23, 2018

Label display none instead of opacity 0

Issue #46

Copy link
Contributor

@basmulderdnz basmulderdnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder '%label-active-transition' still has the opacity value set (to 1). This should be switched to 'display' as well in order to work.

@pascalalferink
Copy link

I have made changes:

  • display: none has been reverted, because with .label-top the label moves to the top, and should not be hidden.
  • pointer-events: none is added to prevent that the element is clickable.

@dariusrosendahl dariusrosendahl changed the base branch from master to develop February 20, 2018 10:46
Copy link
Member

@dariusrosendahl dariusrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix for all browsers + IE11 and higher

@dariusrosendahl dariusrosendahl merged commit 4537ccb into develop Feb 20, 2018
@dariusrosendahl dariusrosendahl deleted the feature/invisible-label branch February 20, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants