Skip to content

Conversation

@Smarker
Copy link
Contributor

@Smarker Smarker commented Feb 28, 2018

  • Fixes any incorrect pipelinekeys, streamfactories
  • Only shows one stream factory - facebook and instagram have two

@Smarker Smarker requested a review from c-w February 28, 2018 20:41
Facebook: {
pipelineKey: 'Facebook',
pipelineLabel: 'Facebook',
pipelineIcon: 'Facebook Icon',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be font-awesome class-names? Like fa fa-facebook-official or fa fa-twitter (the latter we use in some of the seed data).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into that

@kevinhartman
Copy link
Collaborator

I was only able to take a quick look here, but I'd like to note that the concept of a Stream Factory should not be exposed to the user (not sure if it is in this PR, but I'm mentioning it just in case). The correct factory should be chosen based on the settings provided by the user. In some cases, this may be implemented with a drop-down to select an identifier which is one-to-one mapped with an underlying stream factory, but this should not be strictly true.

@Smarker
Copy link
Contributor Author

Smarker commented Feb 28, 2018

yes I agree, I didn't label it as stream factory, but it's good to note. from your comment, when you said settings provided by the user I thought of an idea. Rather than having them enter in the factory, we can just interpret the factory based on the fields they enter. (that way there's no need to have another select option the user needs to fill out)

e.g. for Instagram:
show both tags and location -> if they fill out both then create 2 records (one for instagramTag factory and one for instagramLocation factory)

@kevinhartman
Copy link
Collaborator

Perfect!

@c-w c-w merged commit 126e5f6 into CatalystCode:master Feb 28, 2018
@Smarker Smarker deleted the schema branch February 28, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants